Less strict throwing of runtime error#52
Open
tomdeblauwe wants to merge 1 commit intofacontidavide:mainfrom
Open
Less strict throwing of runtime error#52tomdeblauwe wants to merge 1 commit intofacontidavide:mainfrom
tomdeblauwe wants to merge 1 commit intofacontidavide:mainfrom
Conversation
While encoding, sometimes there can be a timeout in the compressionWorker but actually, it's not that anything is broken, it's just that the system is very busy at startup. So throwing a runtime error is too much because there no possible option to disable it, or catch it: a try catch around the encode function won't do it because it is in another thread when using compression. Signed-off-by: tomdeblauwe <tom.deblauwe@zygo.be>
Owner
|
the reason why I originally added that is that this is NOT supposed to happen and it is generally a signal that we are ingesting data to compress faster than we can compress it. Probably the right solution is also to add a maximum memory / buffer size and drop older messages that we can not keep up with |
Contributor
Author
|
What would also be nice is that you can choose not to use a thread. Now that is only possible when not using compression. So would be nice to allow this even when using compression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While encoding, sometimes there can be a timeout in the compressionWorker but actually, it's not that anything is broken, it's just that the system is very busy at startup. So throwing a runtime error is too much because there no possible option to disable it, or catch it: a try catch around the encode function won't do it because it is in another thread when using compression.