refactor(react): reorganize Storybook sidebar structure (part 2)#3837
Open
eliseo-juan wants to merge 5 commits intomainfrom
Open
refactor(react): reorganize Storybook sidebar structure (part 2)#3837eliseo-juan wants to merge 5 commits intomainfrom
eliseo-juan wants to merge 5 commits intomainfrom
Conversation
Contributor
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
Contributor
📦 Alpha Package Version PublishedUse Use |
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the Storybook sidebar reorganization by moving components into clearer maturity/purpose buckets (patterns/kits/lib/sds/deprecated) and updating imports/stories to point at the new canonical locations, while keeping deprecated re-exports for backwards compatibility.
Changes:
- Updated many imports to reflect new canonical paths (notably
OneEllipsis,F0Dialog,OneFilterPicker,F0FilterPickerContent,Reactions,VirtualList,ToggleGroup). - Added/moved Storybook stories/docs and simplified Storybook
titlevalues to align with the new sidebar structure (including adding aDeprecateddirectory entry). - Introduced new pattern modules (
patterns/F0Dialog,patterns/F0FilterPickerContent,patterns/OneFilterPicker,patterns/SectionHeader) and new SDS/kit modules (sds/Home/DaytimePage,kits/Social/Reactions).
Reviewed changes
Copilot reviewed 148 out of 227 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/ui/value-display/types/text/text.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/ui/value-display/types/person/person.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/ui/value-display/types/longText/longText.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/ui/value-display/types/country/country.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/ui/Text/Text.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/ui/InputField/components/Label.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/ui/InputField/AppendTag.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/ui/InputField/stories/InputField.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/ui/F0Wizard/types.ts | Update dialog types import to patterns/F0Dialog. |
| packages/react/src/ui/F0Wizard/F0Wizard.tsx | Update dialog imports to patterns/F0Dialog. |
| packages/react/src/ui/F0Wizard/stories/F0Wizard.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/ui/Card/stories/Card.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/ui/Action/stories/Action.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/sds/surveys/SurveyFormBuilder/QuestionTypes/BaseScoreQuestion/ScoreEditOption.tsx | Update Reactions picker CSS import to kits path. |
| packages/react/src/sds/surveys/SurveyFormBuilder/Form/TableOfContent/index.tsx | Update F0DialogContext import to patterns/F0Dialog. |
| packages/react/src/sds/surveys/SurveyFormBuilder/Form/LastQuestionDialog.tsx | Switch legacy Dialog import to deprecated/Dialog. |
| packages/react/src/sds/surveys/SurveyAnsweringForm/types.ts | Update dialog types import to patterns/F0Dialog. |
| packages/react/src/sds/surveys/SurveyAnsweringForm/SurveyAnsweringForm.tsx | Update F0Dialog import to patterns/F0Dialog. |
| packages/react/src/sds/Home/DaytimePage/index.tsx | New SDS DaytimePage component under sds/Home. |
| packages/react/src/sds/Home/DaytimePage/index.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/sds/Home/Communities/Post/CommunityPost/index.tsx | Update Reactions import to kits path. |
| packages/react/src/sds/Home/Communities/Celebration/components/avatar.tsx | Update Picker import to kits path. |
| packages/react/src/sds/ai/F0AiChat/components/layout/CreditsPopover.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/components/layout/ChatHeader.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/components/input/ToolHintSelector.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/components/input/MentionPopover.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/components/input/ChatInput.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/components/history/components/ThreadItem.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/components/history/ChatHistoryDialog.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/components/feedback/FeedbackModal.tsx | Update F0Dialog import to patterns/F0Dialog. |
| packages/react/src/sds/ai/F0AiChat/canvas/entities/dashboard/DashboardHeader.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/F0AiChat/canvas/entities/dashboard/DashboardContent.tsx | Update OneFilterPicker types import to patterns path. |
| packages/react/src/sds/ai/F0AiChat/canvas/components/CanvasCard.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/Banners/F0Callout/CalloutInternal.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/sds/ai/Banners/F0AiBanner/AiBannerInternal.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/SectionHeader/index.tsx | New SectionHeader pattern component. |
| packages/react/src/patterns/SectionHeader/index.stories.tsx | Story uses canonical icons import path. |
| packages/react/src/patterns/SectionHeader/index.mdx | New MDX docs for SectionHeader. |
| packages/react/src/patterns/OneFilterPicker/utils.ts | New URL/base64 helpers for filters state. |
| packages/react/src/patterns/OneFilterPicker/types.ts | New canonical filter/preset types module. |
| packages/react/src/patterns/OneFilterPicker/internal/getPresetCoveredKeys.ts | New helper to compute preset-covered keys. |
| packages/react/src/patterns/OneFilterPicker/internal/getPresetCoveredKeys.test.ts | Tests for preset-covered-keys helper. |
| packages/react/src/patterns/OneFilterPicker/internal/getActiveFilterKeys.ts | New helper to compute active filter keys. |
| packages/react/src/patterns/OneFilterPicker/index.tsx | New public barrel for OneFilterPicker pattern. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/utils.ts | New filterTypes utility helpers (defaults + lookup). |
| packages/react/src/patterns/OneFilterPicker/filterTypes/types.ts | New filterTypes typing surface. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/SearchFilter/SearchFilter.tsx | New SearchFilter implementation. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/SearchFilter/index.tsx | Search filter type definition + export. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/SearchFilter/stories/SearchFilter.stories.tsx | Stories for SearchFilter. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/NumberFilter/index.tsx | Number filter type definition + export. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/NumberFilter/stories/NumberFilter.stories.tsx | Stories for NumberFilter. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/useLoadOptions.ts | Options loading + caching for InFilter. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/types.ts | InFilter option types + source integration types. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/InFilter.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/index.tsx | InFilter type definition + chip label logic. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/components/option-utils.ts | New utilities for nested option search/selection. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/components/InFilterOptionRow.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/components/InFilterFlatOption.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/InFilter/tests/InFilter.test.tsx | New InFilter tests. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/index.tsx | Barrel exports for filterTypes. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/filters.tsx | Registry of filter type implementations + value typing. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/DateFilter/index.tsx | Date filter type definition + export. |
| packages/react/src/patterns/OneFilterPicker/filterTypes/DateFilter/DateFilter.tsx | DateFilter UI implementation. |
| packages/react/src/patterns/OneFilterPicker/exports.ts | Exports for OneFilterPicker consumer surface. |
| packages/react/src/patterns/OneFilterPicker/context.ts | New FiltersContext and typing. |
| packages/react/src/patterns/OneFilterPicker/components/FiltersPresets.tsx | Presets rendering + counters/overflow behavior. |
| packages/react/src/patterns/OneFilterPicker/components/FiltersControls.tsx | Update dialog/filter-picker imports to patterns. |
| packages/react/src/patterns/OneFilterPicker/components/FiltersChipsList.tsx | New chip list for active filters. |
| packages/react/src/patterns/OneFilterPicker/components/FilterList.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/OneFilterPicker/components/FilterContent.tsx | New right-pane renderer for selected filter. |
| packages/react/src/patterns/OneFilterPicker/components/FilterChipButton.tsx | New chip button with async label support. |
| packages/react/src/patterns/OneFilterPicker/test/filters-presets-counter.test.tsx | Tests ensuring preset counters match in overflow UI. |
| packages/react/src/patterns/OneFilterPicker/stories/presets.mdx | New MDX docs for presets usage. |
| packages/react/src/patterns/OneFilterPicker/stories/OneFiltersPicker.internal.mdx | New internal MDX docs for composition API. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/VisualizationRenderer.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/types.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/Table/settings/SettingsRenderer.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/Table/components/SortAndHideList/SortAndHideList.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/Table/components/Row.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/Table/components/NestedRow.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/List/types.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/List/index.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/List/components/ListSkeleton.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/List/components/ListGroup.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/List/components/ItemTeaser.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/Kanban/Kanban.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/collectionViewRegistry.tsx | Update OneFilterPicker import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations/collection/Card/index.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/visualizations.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/useEventEmitter.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/types.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/Settings/VisualizationSettingsRenderer.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/Settings/Settings.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/Settings/components/VisualizationSelector.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/OneDatacollection.tsx | Update OneFilterPicker import to patterns path. |
| packages/react/src/patterns/OneDataCollection/hooks/usePerVisualizationFilters.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/exports.ts | Re-export OneFilterPicker exports from patterns path. |
| packages/react/src/patterns/OneDataCollection/components/itemActions/useItemActions.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/components/ActionBar/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/OneDataCollection/tests/index.spec.tsx | Update OneFilterPicker types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/stories/mockData.tsx | Update OneFilterPicker types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/stories/empty-states.stories.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/OneDataCollection/stories/actions/collection-actions.stories.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/F0FilterPickerContent/types.ts | New types for standalone filter picker content pattern. |
| packages/react/src/patterns/F0FilterPickerContent/internal.tsx | New shared internal renderer for filter picker content. |
| packages/react/src/patterns/F0FilterPickerContent/internal-types.ts | New shared internal props/types. |
| packages/react/src/patterns/F0FilterPickerContent/index.ts | New barrel exports for F0FilterPickerContent. |
| packages/react/src/patterns/F0FilterPickerContent/F0FilterPickerContent.tsx | New standalone dual-pane filter picker content component. |
| packages/react/src/patterns/F0Dialog/utils.ts | New small-screen media query helper. |
| packages/react/src/patterns/F0Dialog/types.ts | New canonical dialog types. |
| packages/react/src/patterns/F0Dialog/internal-types.ts | New internal types for dialog provider/internal component. |
| packages/react/src/patterns/F0Dialog/index.tsx | New pattern entrypoint + exports for dialog context/types. |
| packages/react/src/patterns/F0Dialog/F0DialogInternal.tsx | New internal dialog implementation (dialog/drawer variants). |
| packages/react/src/patterns/F0Dialog/F0Dialog.tsx | Thin wrapper exporting the internal dialog. |
| packages/react/src/patterns/F0Dialog/components/F0DialogProvider.tsx | New dialog context provider + hook. |
| packages/react/src/patterns/F0Dialog/components/F0DialogHeader.tsx | New dialog header implementation (module/actions/tabs). |
| packages/react/src/patterns/F0Dialog/components/F0DialogFooter.tsx | New dialog footer actions renderer. |
| packages/react/src/patterns/F0Dialog/components/F0DialogContent.tsx | New dialog scrollable content with shadows. |
| packages/react/src/patterns/F0AnalyticsDashboard/types.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/hooks/useDashboardItemData.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/hooks/useDashboardExport.ts | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/F0AnalyticsDashboard.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/components/MetricItem/MetricItem.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/components/FilterBar/FilterBar.tsx | Update OneFilterPicker import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/components/DashboardItem/DashboardItem.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/patterns/F0AnalyticsDashboard/components/DashboardGrid/DashboardGrid.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/components/CollectionItem/CollectionItem.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/components/ChartItem/ChartItem.tsx | Update filter types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/stories/mockDataMixed.ts | Update presets types import to patterns path. |
| packages/react/src/patterns/F0AnalyticsDashboard/stories/index.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/lib/VirtualList/index.tsx | Fix internal import to use @/lib/utils. |
| packages/react/src/lib/VirtualList/index.stories.tsx | New VirtualList story under simplified title. |
| packages/react/src/lib/providers/datacollection/types.ts | Update filter types import to patterns path. |
| packages/react/src/lib/OneEllipsis/OneEllipsis.test.tsx | New tests for OneEllipsis in lib. |
| packages/react/src/lib/OneEllipsis/index.tsx | New barrel export for OneEllipsis. |
| packages/react/src/lib/OneEllipsis/stories/OneEllipsis.stories.tsx | New OneEllipsis stories under simplified title. |
| packages/react/src/lib/exports.ts | Re-export OneEllipsis from lib. |
| packages/react/src/kits/Social/Reactions/reaction.tsx | New Reaction component for Social Reactions kit. |
| packages/react/src/kits/Social/Reactions/Picker/index.tsx | New emoji picker popover for Reactions kit. |
| packages/react/src/kits/Social/Reactions/Picker/index.css | New styling for emoji picker. |
| packages/react/src/kits/Social/Reactions/index.tsx | New Reactions kit component entrypoint. |
| packages/react/src/kits/Social/Reactions/index.stories.tsx | Adjust story title to Social/Reactions. |
| packages/react/src/kits/F0DataChart/components/FunnelChart/FunnelChart.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/hooks/datasource/useSelectable/useSelectable.ts | Update filter types import to patterns path. |
| packages/react/src/hooks/datasource/useData.ts | Update filter types import to patterns path. |
| packages/react/src/hooks/datasource/types/selection.typings.ts | Update filter types import to patterns path. |
| packages/react/src/hooks/datasource/types/grouping.typings.ts | Update filter types import to patterns path. |
| packages/react/src/hooks/datasource/types/filters.typings.ts | Re-export filter typings from patterns path. |
| packages/react/src/hooks/datasource/types/fetch.typings.ts | Update filter types import to patterns path. |
| packages/react/src/hooks/datasource/types/datasource.typings.ts | Update filter types import to patterns path. |
| packages/react/src/hooks/datasource/index.ts | Re-export filter types from patterns path. |
| packages/react/src/hooks/datasource/test/useData.spec.tsx | Update filter types import to patterns path. |
| packages/react/src/experimental/Widgets/Content/Weekdays/index.tsx | Update ToggleGroup import to deprecated path. |
| packages/react/src/experimental/RichText/NotesTextEditor/Header/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/experimental/RichText/CoreEditor/Toolbar/index.tsx | Update Picker import to kits path. |
| packages/react/src/experimental/Overlays/exports.tsx | Deprecation re-export for Dialog from deprecated/Dialog. |
| packages/react/src/experimental/Navigation/Header/Breadcrumbs/types.ts | Update OneFilterPicker import to patterns path. |
| packages/react/src/experimental/Navigation/Header/Breadcrumbs/index.stories.tsx | Update OneFilterPicker import to patterns path. |
| packages/react/src/experimental/Navigation/F0TableOfContent/Item/PrimitiveItem.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/experimental/Navigation/F0TableOfContent/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/experimental/Navigation/exports.tsx | Deprecation re-exports for DaytimePage and VirtualList. |
| packages/react/src/experimental/Information/Headers/exports.ts | Deprecation re-export for SectionHeader from patterns. |
| packages/react/src/experimental/Information/exports.tsx | Deprecation re-export for Reactions from kits. |
| packages/react/src/experimental/Forms/Fields/ToggleGroup/index.tsx | Update ToggleGroup export to deprecated path. |
| packages/react/src/experimental/Forms/Fields/ToggleGroup/index.stories.tsx | Update ToggleGroup imports to deprecated path. |
| packages/react/src/experimental/Forms/exports.tsx | Deprecation re-export for EntitySelect from deprecated path. |
| packages/react/src/experimental/F0VersionHistory/VersionItem/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/experimental/F0VersionHistory/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/experimental/F0VersionHistory/CurrentVersionIndicator/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/experimental/F0VersionHistory/stories/F0VersionHistory.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/deprecated/ToggleGroup/ToggleGroup.tsx | Update imports to canonical @/lib/utils and @/ui/toggle. |
| packages/react/src/deprecated/ToggleGroup/index.tsx | New barrel export for deprecated ToggleGroup. |
| packages/react/src/deprecated/EntitySelect/utils.ts | New helper util for EntitySelect sub-entity mapping. |
| packages/react/src/deprecated/EntitySelect/types.ts | Update Action import path for EntitySelect typing. |
| packages/react/src/deprecated/EntitySelect/Trigger/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/deprecated/EntitySelect/Trigger/index.stories.tsx | New Trigger stories with updated sidebar title. |
| packages/react/src/deprecated/EntitySelect/ListTag/index.tsx | Update types import to deprecated EntitySelect types. |
| packages/react/src/deprecated/EntitySelect/ListTag/index.stories.tsx | New ListTag stories. |
| packages/react/src/deprecated/EntitySelect/ListItem/index.stories.tsx | New ListItem stories. |
| packages/react/src/deprecated/EntitySelect/index.tsx | Update utils import to canonical @/lib/utils. |
| packages/react/src/deprecated/EntitySelect/index.mdx | New MDX docs for deprecated EntitySelect. |
| packages/react/src/deprecated/EntitySelect/HighLightText/index.tsx | Update utils import to canonical @/lib/utils. |
| packages/react/src/deprecated/EntitySelect/groups-avatar-name.factory.tsx | Fix storybook asset import path. |
| packages/react/src/deprecated/EntitySelect/exports.tsx | New exports barrel for deprecated EntitySelect. |
| packages/react/src/deprecated/EntitySelect/entity-select-name.factory.tsx | Fix storybook asset import path. |
| packages/react/src/deprecated/EntitySelect/CreateItem/index.tsx | New “create” row component for EntitySelect. |
| packages/react/src/deprecated/EntitySelect/Content/SecondaryContent/index.tsx | Update VirtualList import to lib/VirtualList. |
| packages/react/src/deprecated/EntitySelect/Content/MainContent/Searcher.tsx | Update F0Icon import to canonical path. |
| packages/react/src/deprecated/EntitySelect/Content/MainContent/index.tsx | Update Action/cn/VirtualList imports to canonical paths. |
| packages/react/src/deprecated/EntitySelect/Content/MainContent/Footer.tsx | Update Action import to canonical path. |
| packages/react/src/deprecated/EntitySelect/Content/index.tsx | Update Action import to canonical path. |
| packages/react/src/deprecated/Dialog/index.tsx | New deprecated Dialog component (moved from experimental). |
| packages/react/src/deprecated/Dialog/index.stories.tsx | Story title adjusted for new sidebar structure. |
| packages/react/src/components/tags/internal/BaseTag/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/Navigation/Sidebar/Menu/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/Navigation/Sidebar/Footer/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/Navigation/Sidebar/CompanySelector/index.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/F0WizardForm/types.ts | Update dialog types import to patterns/F0Dialog. |
| packages/react/src/components/F0Select/F0Select.tsx | Update F0DialogContext import to patterns/F0Dialog. |
| packages/react/src/components/F0Select/components/SelectTopActions.tsx | Update OneFilterPicker import path; canonicalize F1SearchBox import. |
| packages/react/src/components/F0Select/components/SelectItem.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/F0Select/components/SelectionPreview.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/F0Select/components/SelectedItems.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/F0Select/components/SelectAll.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/F0Select/components/ActiveFiltersChips.tsx | Update filterTypes import to patterns path. |
| packages/react/src/components/F0Form/F0AiFormPresenter.tsx | Update F0Dialog import to patterns/F0Dialog. |
| packages/react/src/components/F0Form/components/SectionRenderer.tsx | Update SectionHeader import to patterns/SectionHeader. |
| packages/react/src/components/F0Form/components/F0FormSection.tsx | Update SectionHeader import to patterns/SectionHeader. |
| packages/react/src/components/F0Form/stories/F0Form.stories.tsx | Update F0Dialog import to patterns/F0Dialog. |
| packages/react/src/components/F0Card/CardInternal.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/F0Button/internal.tsx | Update OneEllipsis import to new lib location. |
| packages/react/src/components/exports.ts | Add deprecated re-exports to keep backwards compatibility while moving modules. |
| packages/react/.storybook/main.ts | Add Deprecated category/directory to Storybook config. |
Move components between sections to better reflect their maturity and purpose: - Add 'Deprecated' category to Storybook main.ts - Move experimental/Overlays/Dialog → deprecated/Dialog - Move components/F0Dialog → patterns/F0Dialog - Move components/OneFilterPicker → patterns/OneFilterPicker - Move components/F0FilterPickerContent → patterns/F0FilterPickerContent - Move components/OneEllipsis → lib/OneEllipsis - Move experimental/Forms → experimental/Forms (reverted back) - Move experimental/Forms/EntitySelect → deprecated/EntitySelect - Move experimental/Navigation/VirtualList → lib/VirtualList - Move experimental/Navigation/DaytimePage → sds/Home/DaytimePage - Move experimental/Information/Reactions → kits/Social/Reactions - Move experimental/Information/Headers/SectionHeader → patterns/SectionHeader - Move ui/toggleGroup.tsx → deprecated/ToggleGroup/ Add @deprecated re-exports in source sections for backward compatibility. Update all @/ alias imports across the codebase to point to new paths.
eliseo-juan
force-pushed
the
refactor/storybook-sidebar-reorganization-2
branch
from
18ab84e to
f4dccfb
Compare
Comment on lines
+61
to
+76
| export { OneFilterPicker } from "../patterns/OneFilterPicker/OneFilterPicker" | ||
| export type { | ||
| DateFilterDefinition, | ||
| FilterDefinition, | ||
| FilterValue, | ||
| InFilterDefinition, | ||
| NumberFilterDefinition, | ||
| SearchFilterDefinition, | ||
| FilterValueByKey, | ||
| FiltersMode, | ||
| FiltersDefinition, | ||
| FilterOptions, | ||
| CurrentFilters, | ||
| PresetDefinition, | ||
| PresetsDefinition, | ||
| } from "../patterns/OneFilterPicker/types" |
There was a problem hiding this comment.
This replaces the previous export * from "./OneFilterPicker/exports" pattern with a narrower set of exports (component + selected types). If consumers relied on any additional runtime exports previously surfaced via ./OneFilterPicker/exports (e.g., helpers/constants/subcomponents), this becomes a breaking change and conflicts with the PR’s “backward compatibility” claim. Consider re-exporting the full public surface from the new canonical location (and marking it @deprecated) rather than hand-picking symbols, or ensure all previously-exported symbols are still available from @/components.
Suggested change
| export { OneFilterPicker } from "../patterns/OneFilterPicker/OneFilterPicker" | |
| export type { | |
| DateFilterDefinition, | |
| FilterDefinition, | |
| FilterValue, | |
| InFilterDefinition, | |
| NumberFilterDefinition, | |
| SearchFilterDefinition, | |
| FilterValueByKey, | |
| FiltersMode, | |
| FiltersDefinition, | |
| FilterOptions, | |
| CurrentFilters, | |
| PresetDefinition, | |
| PresetsDefinition, | |
| } from "../patterns/OneFilterPicker/types" | |
| export * from "../patterns/OneFilterPicker/exports" |
| } from "react" | ||
|
|
||
| import { OneEllipsis } from "@/components/OneEllipsis/OneEllipsis" | ||
| import { OneEllipsis } from "@/lib/OneEllipsis/OneEllipsis" |
There was a problem hiding this comment.
This is a deep import into the implementation file. Since OneEllipsis is now exposed via @/lib/OneEllipsis (and packages/react/src/lib/exports.ts), prefer importing from the package entrypoint to reduce coupling to internal file structure and make future moves/refactors cheaper.
Suggested change
| import { OneEllipsis } from "@/lib/OneEllipsis/OneEllipsis" | |
| import { OneEllipsis } from "@/lib/OneEllipsis" |
| import { forwardRef } from "react" | ||
|
|
||
| import { ToggleGroup, ToggleGroupItem } from "@/ui/toggleGroup" | ||
| import { ToggleGroup, ToggleGroupItem } from "@/deprecated/ToggleGroup" |
There was a problem hiding this comment.
Importing directly from @/deprecated/ToggleGroup makes this experimental widget depend on a deprecated module path. Since you already added an experimental re-export (experimental/Forms/Fields/ToggleGroup), consider importing from @/experimental/Forms/Fields/ToggleGroup instead so the experimental area doesn’t “pin” itself to deprecated internals and can be re-routed centrally later.
Suggested change
| import { ToggleGroup, ToggleGroupItem } from "@/deprecated/ToggleGroup" | |
| import { | |
| ToggleGroup, | |
| ToggleGroupItem, | |
| } from "@/experimental/Forms/Fields/ToggleGroup" |
| @@ -1,2 +1,3 @@ | |||
| export { Dialog } from "./Dialog" | |||
| /** @deprecated Dialog has moved to @/deprecated/Dialog. Import from there instead. */ | |||
| export { Dialog } from "../../deprecated/Dialog" | |||
There was a problem hiding this comment.
The deprecation message points to an absolute import (@/deprecated/Dialog) but the re-export uses a relative path. For consistency with the rest of the refactor (and to avoid path churn if folders move again), prefer using the same absolute alias in the re-export as well.
Suggested change
| export { Dialog } from "../../deprecated/Dialog" | |
| export { Dialog } from "@/deprecated/Dialog" |
|
|
||
| import { IconType } from "../../../components/F0Icon" | ||
| import { OneEmptyState } from "../../OneEmptyState/OneEmptyState" | ||
| import { OneEmptyState } from "@/components/OneEmptyState/OneEmptyState" |
There was a problem hiding this comment.
Similar to other moves in this PR, this is a deep import into the component implementation file. Prefer importing OneEmptyState from @/components/OneEmptyState (or the relevant barrel) to keep internal file structure private and minimize future refactor work.
Suggested change
| import { OneEmptyState } from "@/components/OneEmptyState/OneEmptyState" | |
| import { OneEmptyState } from "@/components/OneEmptyState" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorganize the Storybook sidebar structure to better reflect the maturity and purpose of each component. This is part 2 of the ongoing sidebar reorganization effort.
Screenshots (if applicable)
N/A — structural/organizational changes only, no visual output changes.
Implementation details
What changed
components/F0Form→patterns/F0Formcomponents/F0FormField→patterns/F0FormFieldcomponents/F0WizardForm→patterns/F0WizardFormcomponents/Navigation/Sidebar→patterns/Navigation/Sidebarexperimental/Navigation/Page→patterns/Navigation/Pageexperimental/Navigation/Tabs→patterns/Navigation/Tabsexperimental/OneCalendar→components/OneCalendarexperimental/OneEmptyState→components/OneEmptyStateexperimental/RichText/(entire subtree) →components/RichText/components/Utilities/F0GridStack→lib/F0GridStack@/experimental/OneCalendar/typesimport in.storybook/preview.tsxWhy
The previous sidebar structure mixed components of different maturity levels and purposes within the same sections. This reorganization makes it clearer to consumers which components are stable patterns, which are internal utilities, and which have graduated from experimental to stable.
Backward compatibility
All moved components retain
@deprecatedre-exports at their original locations, so existing imports across the codebase continue to work. All@/absolute imports were updated to point to the new canonical locations.