Skip to content

refactor(F0BigNumber): promote from experimental to stable#3842

Open
eliseo-juan wants to merge 2 commits intorefactor/storybook-sidebar-reorganization-2from
stabilize/F0BigNumber
Open

refactor(F0BigNumber): promote from experimental to stable#3842
eliseo-juan wants to merge 2 commits intorefactor/storybook-sidebar-reorganization-2from
stabilize/F0BigNumber

Conversation

@eliseo-juan
Copy link
Copy Markdown
Contributor

Summary

  • Removes experimentalComponent() wrapper from F0BigNumber export
  • Removes unused import { experimentalComponent } from "@/lib/experimental"
  • Updates story tags from experimental to stable

Changes

  • packages/react/src/components/F0BigNumber/index.tsx: simplified export using withDataTestId(F0BigNumberCmp) directly
  • packages/react/src/components/F0BigNumber/__stories__/F0BigNumber.stories.tsx: updated tags to ["autodocs", "stable"]

@eliseo-juan eliseo-juan requested a review from a team as a code owner April 2, 2026 22:47
Copilot AI review requested due to automatic review settings April 2, 2026 22:47
@github-actions github-actions bot added refactor react Changes affect packages/react labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes F0BigNumber from experimental to stable within the React component library by removing the experimental wrapper and aligning Storybook metadata tags with stable status.

Changes:

  • Remove experimentalComponent() wrapper from F0BigNumber’s public export, leaving withDataTestId(F0BigNumberCmp) as the only wrapper.
  • Update Storybook tags from experimental to stable for F0BigNumber (and F0Heading).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/components/F0BigNumber/index.tsx Removes experimental wrapper from the exported component, keeping the withDataTestId export path.
packages/react/src/components/F0BigNumber/stories/F0BigNumber.stories.tsx Updates Storybook tags to reflect stable status.
packages/react/src/components/F0Heading/stories/Heading.stories.tsx Updates Storybook tags to stable (extra scope beyond PR description).

Comment on lines 10 to 14
const meta = {
component: F0Heading,
title: "Heading",
tags: ["autodocs", "experimental"],
tags: ["autodocs", "stable"],
argTypes: {
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file’s Storybook tags were updated from experimental → stable, but the PR title/description only mention promoting F0BigNumber. Please update the PR description to include this change (or split it into a separate PR) so reviewers/release notes aren’t surprised by the extra scope.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

📦 Alpha Package Version Published

Use pnpm i github:factorialco/f0#npm/alpha-pr-3842 to install the package

Use pnpm i github:factorialco/f0#7140d2f79cd463c61d9180d64d1291873795e6ca to install this specific commit

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🔍 Visual review for your branch is published 🔍

Here are the links to:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Coverage Report for packages/react

Status Category Percentage Covered / Total
🔵 Lines 44.88% 10953 / 24403
🔵 Statements 44.14% 11294 / 25582
🔵 Functions 36.86% 2476 / 6716
🔵 Branches 36.74% 7153 / 19469
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/F0BigNumber/index.tsx 0% 100% 100% 0% 6
Generated in workflow #12519 for commit f588987 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

react Changes affect packages/react refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants