refactor(F0Text): promote from experimental to stable#3844
refactor(F0Text): promote from experimental to stable#3844eliseo-juan wants to merge 3 commits intorefactor/storybook-sidebar-reorganization-2from
Conversation
There was a problem hiding this comment.
Pull request overview
Promotes several component Storybook entries from “experimental” to “stable” and (for F0BigNumber) removes the experimental runtime wrapper so it behaves as a stable component in the library.
Changes:
- Update Storybook
tagsfromexperimentaltostablefor F0Text, F0Heading, and F0BigNumber stories. - Remove
experimentalComponent(...)wrapping from the exportedF0BigNumbercomponent (keepswithDataTestId).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/components/F0Text/stories/Text.stories.tsx | Marks F0Text Storybook docs as stable. |
| packages/react/src/components/F0Heading/stories/Heading.stories.tsx | Marks F0Heading Storybook docs as stable. |
| packages/react/src/components/F0BigNumber/index.tsx | Exports F0BigNumber without experimental wrapper (stable runtime behavior). |
| packages/react/src/components/F0BigNumber/stories/F0BigNumber.stories.tsx | Marks F0BigNumber Storybook docs as stable. |
| import { withDataTestId } from "@/lib/data-testid" | ||
| import { experimentalComponent } from "@/lib/experimental" | ||
| export * from "./types" | ||
|
|
||
| import { F0BigNumber as F0BigNumberCmp } from "./F0BigNumber" | ||
|
|
||
| export const F0BigNumber = withDataTestId( | ||
| experimentalComponent<typeof F0BigNumberCmp>("F0BigNumber", F0BigNumberCmp) | ||
| ) | ||
| export const F0BigNumber = withDataTestId(F0BigNumberCmp) |
There was a problem hiding this comment.
The PR title/description says this is promoting F0Text and only updating Storybook tags, but this change also removes the experimentalComponent wrapper from F0BigNumber, which is a runtime behavior change (it stops emitting experimental-usage warnings and effectively promotes F0BigNumber to stable). Please either update the PR metadata/scope to include F0BigNumber (and the Heading story change) or split these promotions into separate PRs so the intent and release impact are clear.
📦 Alpha Package Version PublishedUse Use |
🔍 Visual review for your branch is published 🔍Here are the links to: |
Coverage Report for packages/react
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
Promotes F0Text from experimental to stable status. The component has been in use and is ready for production.
Implementation details