Skip to content

refactor(OneChip): promote from experimental to stable #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliseo-juan wants to merge 3 commits into
base: refactor/storybook-sidebar-reorganization-2
Choose a base branch
from
Open

refactor(OneChip): promote from experimental to stable #3846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbf3c47
refactor(F0Heading): promote from experimental to stable
eliseo-juan Apr 2, 2026
f588987
refactor(F0BigNumber): promote from experimental to stable
eliseo-juan Apr 2, 2026
2194eb1
refactor(OneChip): promote from experimental to stable
eliseo-juan Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/F0BigNumber/__stories__/F0BigNumber.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const meta: Meta<typeof F0BigNumber> = {
},
},
},
tags: ["autodocs", "experimental"],
tags: ["autodocs", "stable"],
argTypes: {
value: {
control: "object",
Expand Down
5 changes: 1 addition & 4 deletions packages/react/src/components/F0BigNumber/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import { withDataTestId } from "@/lib/data-testid"
import { experimentalComponent } from "@/lib/experimental"
export * from "./types"

import { F0BigNumber as F0BigNumberCmp } from "./F0BigNumber"

export const F0BigNumber = withDataTestId(
experimentalComponent<typeof F0BigNumberCmp>("F0BigNumber", F0BigNumberCmp)
)
export const F0BigNumber = withDataTestId(F0BigNumberCmp)
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description focuses on promoting OneChip only, but this PR also changes F0BigNumber (removes experimentalComponent) and updates Storybook tags for F0Heading/F0BigNumber. Please update the PR description (and/or title) to reflect the additional components being promoted to stable, so reviewers and release notes don’t miss these API/status changes.

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion packages/react/src/components/F0Heading/__stories__/Heading.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { F0Heading } from "../index"
const meta = {
component: F0Heading,
title: "Heading",
tags: ["autodocs", "experimental"],
tags: ["autodocs", "stable"],
argTypes: {
variant: {
options: ["heading", "heading-large"],
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/OneChip/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const meta = {
parameters: {
layout: "centered",
},
tags: ["autodocs", "experimental"],
tags: ["autodocs", "stable"],
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip is now promoted to stable, but this Storybook file still lacks the required Snapshot story (using withSnapshot({})) that renders the meaningful variants for Chromatic. Please add a Snapshot story so the component has baseline visual coverage like other stable components.

Copilot uses AI. Check for mistakes.
argTypes: {
label: {
description: "The label of the chip",
Expand Down
6 changes: 1 addition & 5 deletions packages/react/src/components/OneChip/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { cva, type VariantProps } from "cva"
import { F0Avatar, type AvatarVariant } from "@/components/avatars/F0Avatar"
import { F0Icon, type IconType } from "@/components/F0Icon"
import { CrossedCircle } from "@/icons/app"
import { experimentalComponent } from "@/lib/experimental"
import { cn, focusRing } from "@/lib/utils"

export const chipVariants = cva({
Expand Down Expand Up @@ -122,7 +121,4 @@ const _Chip = ({
)
}

Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the experimentalComponent wrapper, the exported component's React name will come from _Chip, which shows up as _Chip in React DevTools/Storybook docs. Consider setting _Chip.displayName = "Chip" (or defining the component as function Chip(...)) so the stable export has a clean, user-facing name.

Suggested change
_Chip.displayName = "Chip"

Copilot uses AI. Check for mistakes.
/**
* @experimental This is an experimental component use it at your own risk
*/
export const Chip = experimentalComponent("Chip", _Chip)
export const Chip = _Chip
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that Chip is being promoted to stable, please ensure its clickable container meets button semantics for assistive tech. The implementation uses a clickable <div>; it should include an appropriate role (e.g. role="button") and relevant ARIA (and ideally use a <button> for the main interactive element) so it is announced and behaves correctly for screen readers.

Copilot uses AI. Check for mistakes.
Loading