refactor(F0Checkbox): promote from experimental to stable#3847
refactor(F0Checkbox): promote from experimental to stable#3847eliseo-juan wants to merge 3 commits intorefactor/storybook-sidebar-reorganization-2from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR promotes components from “experimental” to “stable” within packages/react by removing the experimentalComponent() wrapper/annotations and updating Storybook metadata tags accordingly.
Changes:
- Removed
experimentalComponent()wrapping (and related@experimentalJSDoc / imports) forF0CheckboxandF0ChipList. - Updated Storybook
tagsfrom["autodocs", "experimental"]to["autodocs", "stable"]across multiple stories. - Reformatted
F0DatePickerstories file (notably introducing semicolons throughout).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/components/OneEmptyState/stories/OneEmptyState.stories.tsx | Updates Storybook tag to stable. |
| packages/react/src/components/F0DatePicker/stories/F0DatePicker.stories.tsx | Updates Storybook tag to stable and reformats file (introduces semicolons). |
| packages/react/src/components/F0ChipList/index.tsx | Removes experimentalComponent() wrapper and @experimental JSDoc from F0ChipList. |
| packages/react/src/components/F0ChipList/index.stories.tsx | Updates Storybook tag to stable. |
| packages/react/src/components/F0Checkbox/F0Checkbox.tsx | Removes experimentalComponent() wrapper and @experimental JSDoc from F0Checkbox. |
| packages/react/src/components/F0Checkbox/stories/F0Checkbox.stories.tsx | Updates Storybook tag to stable. |
Comments suppressed due to low confidence (1)
packages/react/src/components/F0Checkbox/F0Checkbox.tsx:109
withDataTestIdderives the wrapped component'sdisplayNamefromcomponent.displayName/component.name. Since the inner function is named_F0Checkbox, React DevTools will show_F0Checkboxinstead ofF0Checkbox. Consider setting_F0Checkbox.displayName = "F0Checkbox"(as many otherF0*components do) before exporting.
/>
)
}
export const F0Checkbox = withDataTestId(_F0Checkbox)
| import type { Meta, StoryObj } from "@storybook/react-vite"; | ||
|
|
||
| import { subDays } from "date-fns" | ||
| import MockDate from "mockdate" | ||
| import { useState } from "react" | ||
| import { expect, fn, within } from "storybook/test" | ||
| import { subDays } from "date-fns"; | ||
| import MockDate from "mockdate"; | ||
| import { useState } from "react"; | ||
| import { expect, fn, within } from "storybook/test"; |
There was a problem hiding this comment.
This story file now uses semicolons (e.g. in the import section), but packages/react/.oxfmtrc.jsonc has "semi": false. This will likely fail format:check; please run the repo formatter (oxfmt) or remove the added semicolons to match the project's formatting rules.
| const meta = { | ||
| component: OneEmptyState, | ||
| title: "EmptyState", | ||
| tags: ["autodocs", "experimental"], | ||
| tags: ["autodocs", "stable"], |
There was a problem hiding this comment.
The PR description/title focuses on promoting F0Checkbox, but this PR also changes other components/stories (e.g. OneEmptyState, F0DatePicker, and F0ChipList). Please update the PR description to reflect the full scope (or split unrelated promotions into separate PRs) so reviewers can assess impact accurately.
📦 Alpha Package Version PublishedUse Use |
🔍 Visual review for your branch is published 🔍Here are the links to: |
Coverage Report for packages/react
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Summary
F0Checkboxfrom experimental to stableexperimentalComponent()wrapper and the@experimentalJSDoc commentimport { experimentalComponent } from "@/lib/experimental""experimental"to"stable"Changes
F0Checkbox.tsx: RemoveexperimentalComponentimport,@experimentalJSDoc, and unwrap the export towithDataTestId(_F0Checkbox)F0Checkbox.stories.tsx: Changetags: ["autodocs", "experimental"]→tags: ["autodocs", "stable"]