refactor(F0DatePicker): promote from experimental to stable#3849
refactor(F0DatePicker): promote from experimental to stable#3849eliseo-juan wants to merge 6 commits intorefactor/storybook-sidebar-reorganization-2from
Conversation
📦 Alpha Package Version PublishedUse Use |
There was a problem hiding this comment.
Pull request overview
Promotes components/stories from “experimental” to “stable” by removing the experimental wrapper from exports and updating Storybook metadata tags so these components are treated as stable in documentation.
Changes:
- Remove
experimentalComponent()wrapping fromF0DatePicker(andF0BigNumber) exports, keepingwithDataTestId. - Update Storybook
tagsfrom["autodocs", "experimental"]to["autodocs", "stable"]for several components.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/components/OneEmptyState/stories/OneEmptyState.stories.tsx | Marks the OneEmptyState story as stable via Storybook tags. |
| packages/react/src/components/F0Text/stories/Text.stories.tsx | Marks F0Text story as stable via Storybook tags. |
| packages/react/src/components/F0Heading/stories/Heading.stories.tsx | Marks F0Heading story as stable via Storybook tags. |
| packages/react/src/components/F0DatePicker/index.ts | Removes experimental export wrapper; exports stable F0DatePicker with withDataTestId. |
| packages/react/src/components/F0DatePicker/stories/F0DatePicker.stories.tsx | Marks F0DatePicker story as stable via Storybook tags. |
| packages/react/src/components/F0BigNumber/index.tsx | Removes experimental export wrapper; exports stable F0BigNumber with withDataTestId. |
| packages/react/src/components/F0BigNumber/stories/F0BigNumber.stories.tsx | Marks F0BigNumber story as stable via Storybook tags. |
| import { withDataTestId } from "@/lib/data-testid" | ||
| import { experimentalComponent } from "@/lib/experimental" | ||
| export * from "./types" | ||
|
|
||
| import { F0BigNumber as F0BigNumberCmp } from "./F0BigNumber" | ||
|
|
||
| export const F0BigNumber = withDataTestId( | ||
| experimentalComponent<typeof F0BigNumberCmp>("F0BigNumber", F0BigNumberCmp) | ||
| ) | ||
| export const F0BigNumber = withDataTestId(F0BigNumberCmp) |
There was a problem hiding this comment.
This PR changes more than the title/description suggest: besides promoting F0DatePicker, it also removes the experimental wrapper from F0BigNumber and flips Storybook tags to "stable" for OneEmptyState, F0Text, and F0Heading. Please either update the PR title/description to cover these additional promotions, or split/revert the unrelated changes to keep scope clear.
| const meta = { | ||
| component: OneEmptyState, | ||
| title: "EmptyState", | ||
| tags: ["autodocs", "experimental"], | ||
| tags: ["autodocs", "stable"], | ||
| argTypes: { | ||
| ...dataTestIdArgs, | ||
| }, |
There was a problem hiding this comment.
This story file doesn't define a Snapshot story using withSnapshot({}). In packages/react, Storybook stories are expected to include a Snapshot story for Chromatic coverage; please add one that renders the meaningful variants of OneEmptyState.
🔍 Visual review for your branch is published 🔍Here are the links to: |
Coverage Report for packages/react
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Summary
experimentalComponent()wrapper fromF0DatePickerexport@experimentalJSDoc comment and unusedexperimentalComponentimport"experimental"to"stable"Changes
packages/react/src/components/F0DatePicker/index.ts— simplified export usingwithDataTestIddirectlypackages/react/src/components/F0DatePicker/__stories__/F0DatePicker.stories.tsx— updated tags to["autodocs", "stable"]