fix(R-SDK) : Fixed CRAN Review Comments#21
Open
vamshimupparaju wants to merge 6 commits into
Open
Conversation
vamshimupparaju
requested review from
Ramanth (Ramanth) and
Sai Giridhar P (saigiridhar21)
Comment on lines
+7
to
+8
| Author: Charlie Mathis Developer [aut, cre] | ||
| Maintainer: Charlie Mathis Developer <chmathis@factset.com> |
Contributor
There was a problem hiding this comment.
I think that we can remove these two lines as the same information is being conveyed in line 5. Can you please confirm it?
Sai Giridhar P (saigiridhar21)
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of below CRAN Review comments :
Please add small executable examples in your Rd-files to illustrate the
use of the exported function but also enable automatic testing.
Please rather use the Authors@R field and declare Maintainer, Authors
and Contributors with their appropriate roles with person() calls.