Make datasets.mv do nothing if source and destination are the same

[liamcoatman]

Make datasets.mv do nothing if source and destination are the same.

Because mv is implemented as cp then rm, the previous behaviour was to delete the file if the source and destination are the same. The new behaviour is to do nothing (like the Unix mv command).

[imrehg]

Good catch!

[acroz]

I suggest we close this in favour of #163. Then, it's the backend's responsibility to get this behaviour right. If the backend implements this behaviour wrongly, we should fix it. Thoughts?

[liamcoatman]

I suggest we close this in favour of #163. Then, it's the backend's responsibility to get this behaviour right. If the backend implements this behaviour wrongly, we should fix it. Thoughts?

Agreed.

[jkeelan]

I disagree, I think we should push this, because it prevents an unexpected and potentially destructive operation. To be clear, #163 also suffers from this issue, so it would have to be fixed on the backend, which will mean a further delay. While solving it on the front end isn't ideal, it's better than nothing.

[acroz]

Fair enough - let's merge this and deal with the backend implementation separately.

[acroz]

Released with 0.26.2