Develop#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings, focusing on better error handling for invalid show types, restructuring the review domain model, and adding a new test for movie searching. The most significant changes are the introduction of a custom exception for invalid show types, moving review-related domain classes into a dedicated subpackage, and updating all relevant imports. Additionally, a new CI workflow is added and a unit test is introduced for movie searching.
Error Handling Improvements
InvalidShowTypeExceptionfor handling invalid show type values, and updated theShowType.from()method to throw this exception instead of a genericIllegalArgumentException. The global exception handler now returns a400 Bad Requestwith a descriptive message when this occurs. [1] [2] [3] [4]Domain Model Refactoring
ReviewandShowTypeclasses fromcom.dizio1.watchvault.review.domaintocom.dizio1.watchvault.review.domain.modelfor better organization. All related imports throughout the codebase have been updated accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]Continuous Integration
.github/workflows/ci.yaml) to run build and test jobs on pushes todevelopand pull requests tomain, including setup for Java, Maven, and a PostgreSQL service.Testing
SearchMovieUseCaseImplTestto verify movie search functionality, including crew member assignment.