Skip to content

Develop#8

Merged
facundoavila05 merged 9 commits into
mainfrom
develop
Mar 3, 2026
Merged

Develop#8
facundoavila05 merged 9 commits into
mainfrom
develop

Conversation

@facundoavila05
Copy link
Copy Markdown
Owner

This pull request introduces several improvements and refactorings, focusing on better error handling for invalid show types, restructuring the review domain model, and adding a new test for movie searching. The most significant changes are the introduction of a custom exception for invalid show types, moving review-related domain classes into a dedicated subpackage, and updating all relevant imports. Additionally, a new CI workflow is added and a unit test is introduced for movie searching.

Error Handling Improvements

  • Added a custom exception InvalidShowTypeException for handling invalid show type values, and updated the ShowType.from() method to throw this exception instead of a generic IllegalArgumentException. The global exception handler now returns a 400 Bad Request with a descriptive message when this occurs. [1] [2] [3] [4]

Domain Model Refactoring

  • Moved Review and ShowType classes from com.dizio1.watchvault.review.domain to com.dizio1.watchvault.review.domain.model for better organization. All related imports throughout the codebase have been updated accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Continuous Integration

  • Added a new GitHub Actions workflow (.github/workflows/ci.yaml) to run build and test jobs on pushes to develop and pull requests to main, including setup for Java, Maven, and a PostgreSQL service.

Testing

  • Introduced a new unit test SearchMovieUseCaseImplTest to verify movie search functionality, including crew member assignment.

@facundoavila05 facundoavila05 merged commit d7fadca into main Mar 3, 2026
2 checks passed
@facundoavila05 facundoavila05 deleted the develop branch March 3, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant