add prompt password option#134
Open
kamiraux wants to merge 1 commit into
Open
Conversation
Owner
|
It would be much nicer if it could detect if a password is needed and ask if it's not stored in the config file. What do you think? |
Author
|
Detect if a password is needed? You mean if the password is empty? Or try to connect and ask for the password if ever it fails? |
Owner
|
I mean this: try to connect and ask for the password if ever it fails Automation is always a good thing. If you can dynamically request the password instead of failing and having the user dig for the correct option to ask for it, I think the best path is obvious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option to allow prompting for the password instead of having it stored in the config file or put it on the command line. It is way better for security concerns.
It still supports previous behavior without any change.
To use this option:
transmission-remote-cli -c user@host --prompt-password
or
transmission-remote-cli -c user@host --prompt-password --create-config