Add 'remove all finished torrents' feature#157
Open
asch wants to merge 1 commit into
Open
Conversation
Add new keybindigs x/X for removing all finished torrents. I.e. every paused torrent with reached seed ratio will be deleted.
alexkubica
suggested changes
Jan 15, 2017
alexkubica
left a comment
alexkubica
left a comment
There was a problem hiding this comment.
I wanted to request for this feature and then I saw your PR, thanks for the work you've done!
|
|
||
| def remove_finished_torrents(self, delete_local_data = False): | ||
| candidates = [torrent for torrent in self.torrents | ||
| if torrent['status'] == Transmission.STATUS_STOPPED |
There was a problem hiding this comment.
I think the status should be compared to Transmission.STATUS_SEED or Transmission.STATUS_SEED_WAIT.
I think Transmission.STATUS_STOPPED means the torrent was paused, but it may not be finished downloading yet.
| def remove_finished_torrents(self, delete_local_data = False): | ||
| candidates = [torrent for torrent in self.torrents | ||
| if torrent['status'] == Transmission.STATUS_STOPPED | ||
| and torrent['uploadRatio'] >= torrent['seedRatioLimit']] |
There was a problem hiding this comment.
I think this check should be omitted.
People might want to remove all finished torrents regardless the seed ratio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new keybindigs x/X for removing all finished torrents. I.e. every
paused torrent with reached seed ratio will be deleted.