Skip to content

Ignore SIGPIPE to prevent server exit on broken TCP/TLS writes #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RalphSteinhagen merged 1 commit into from
Jan 19, 2026
Merged

Ignore SIGPIPE to prevent server exit on broken TCP/TLS writes #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/majordomo/include/majordomo/Broker.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@ class Broker {
, _subSocket(context, ZMQ_SUB)
, _dnsSocket(context, ZMQ_DEALER) {
assert(mdp::isValidServiceName(brokerName));

opencmw::rest::detail::setupIgnoreSigpipe();

addInternalService("/mmi.dns", [this](BrokerMessage &&message) {
using namespace std::literals;
Expand Down
19 changes: 19 additions & 0 deletions src/rest/include/rest/RestUtils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
#include <nghttp2/nghttp2.h>
#include <nghttp3/nghttp3.h>

#include <signal.h>

#ifdef OPENCMW_DEBUG_HTTP
#include <iostream>
#define HTTP_DBG(...) std::println(std::cerr, __VA_ARGS__);
Expand Down Expand Up @@ -468,6 +470,23 @@ struct WriteBuffer {
}
};


// Temporary SIGPIPE mitigation. We currently intercept SIGPIPE to prevent the process from terminating on broken sockets
// (e.g. client aborts during TLS/HTTP write). Revisit this later and decide on the final production behavior.
inline void sigpipeHandler(int) {
const char msg[] = "opencmw: SIGPIPE. Usually caused by client disconnect/reset during TLS/HTTP write.\n";
::write(STDERR_FILENO, msg, sizeof(msg) - 1);
}

inline void setupIgnoreSigpipe() {
struct sigaction sa {};
sa.sa_handler = sigpipeHandler;
sigemptyset(&sa.sa_mask);
sa.sa_flags = 0;
::sigaction(SIGPIPE, &sa, nullptr);
}


} // namespace opencmw::rest::detail

#endif