feat: download shared data without auth#117
Conversation
IgorShadurin
changed the title
| async downloadFromSharedPod(podReference: string | EncryptedReference, fullPath: string): Promise<Data> { | ||
| assertEncryptedReference(podReference) | ||
|
|
||
| const info = await getSharedPodInfo(this.accountData.connection.bee, podReference) |
There was a problem hiding this comment.
it can be executed without authentication as it states but the first parameter of getSharedPodInfo comes from this.accountData. without authentication it should be null, shouldn't it?
There was a problem hiding this comment.
In the current implementation, it will never be null, because after the connection is created, it is stored in this instance.
| const info = await this.getSharedInfo(fileReference) | ||
| const data = await downloadData( | ||
| this.accountData.connection.bee, | ||
| combine(info.meta.file_path, info.meta.file_name), | ||
| prepareEthAddress(info.source_address), | ||
| this.accountData.connection.options?.downloadOptions, | ||
| ) |
There was a problem hiding this comment.
which is really strange for me is that you only need the file path and the ethereum address of the feed owner from the info.
Even if the info lies under an encrypted reference, the data that can be downloaded by that is unenrypted.
I thought by resolving #19 these problems disappeared.
IgorShadurin
changed the title
IgorShadurin
force-pushed
the
68-download-shared-data-from-pod-without-auth
branch
from
dd2f45b to
7a20b02
Compare
IgorShadurin
force-pushed
the
68-download-shared-data-from-pod-without-auth
branch
from
7a20b02 to
b813c0c
Compare
|
This PR has been open for over 3 years (since August 2022) and has CHANGES_REQUESTED status. Is this still active? Please update with requested changes or close if abandoned. |
|
This PR has been open for over 3 years (since August 2022) with CHANGES_REQUESTED status. The feature to download shared data without auth may now be outdated or already addressed elsewhere. Action required:
|
3 participants
Close #68