Skip to content

fix!: bmtHashString replaced with keccak256Hash#223

Open
IgorShadurin wants to merge 2 commits into
masterfrom
fix/217-epoch-id-calculation
Open

fix!: bmtHashString replaced with keccak256Hash#223
IgorShadurin wants to merge 2 commits into
masterfrom
fix/217-epoch-id-calculation

Conversation

@IgorShadurin
Copy link
Copy Markdown
Contributor

@IgorShadurin IgorShadurin commented Mar 13, 2023

Close: #217
Close: #204

@IgorShadurin IgorShadurin requested a review from nugaon as a code owner March 13, 2023 10:33
Copy link
Copy Markdown
Collaborator

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IgorShadurin
Copy link
Copy Markdown
Contributor Author

@asabya Topic calculation changes are ready and checked. I will be ready to merge and make a release after the release of FairOS with similar changes.

@plur9
Copy link
Copy Markdown
Member

plur9 commented Apr 18, 2026

This PR has been open for over 3 years (since March 2023) and is marked APPROVED. If still relevant, please merge. Otherwise, close if superseded by newer changes.

@plur9
Copy link
Copy Markdown
Member

plur9 commented Apr 18, 2026

This PR has been open for over 3 years (since March 2023). Despite being APPROVED, it has remained unmerged. The changes (replacing bmtHashString with keccak256Hash) may now be outdated or already integrated elsewhere.

Action required:

  • If this is still relevant, please rebase against current main, update dependencies, and re-request review
  • If superseded by other work, please close this PR
  • If no response within 14 days, this PR will be closed as stale

cc @IgorShadurin

@plur9
Copy link
Copy Markdown
Member

plur9 commented Apr 27, 2026

Stale PR check — 2026-04-27 (CTO daily cadence)

This PR has been open since 2023-03-13 (over 3 years) with APPROVED status. Is it still relevant or can it be closed? Please update status or close if abandoned.

— CTO review cadence, automated check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EpochID calculation Feed topic is not calculated by design

3 participants