chore: upgrade ethers v6#291
Draft
IgorShadurin wants to merge 3 commits into
Draft
Conversation
tomicvladan
approved these changes
Jan 10, 2024
Member
|
This PR has been open for over 2 years (since November 2023), is marked as DRAFT but has APPROVED status. Is this ready to merge or still work in progress? Please update or close if abandoned. |
Member
|
This DRAFT PR has been open for over 2 years (since November 2023) and is APPROVED. The ethers v6 upgrade is now likely outdated (current version is likely v6.x or even v7.x). Since this is marked as draft but approved, it's unclear if this should be merged or abandoned. Action required:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #286
fdp-contracts should be upgraded with ethers v6 to prevent test errors.