Bump type scale to a 15px base for the IBM Plex switch#37
Conversation
The Lumen alignment swapped Geist -> IBM Plex Sans but kept Involute's 13px base. IBM Plex has a smaller x-height, so text rendered visibly smaller at the same px. Lumen itself is designed around a 15px base. Uniformly uplift the whole type scale +2px (~15%), preserving every density ratio: app.css font-size values and the inline fontSize literals in the kanban/detail/route components. Computed sizes (Avatar Math.max/size*0.5) are left untouched. Base body is now 15px (Lumen's native base); comfortably larger than the prior Geist 13px.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Follow-up to #36. After swapping Geist → IBM Plex Sans, text read visibly smaller because IBM Plex has a smaller x-height while the app kept Involute's 13px base. Lumen itself is designed around a 15px base.
Fix
Uniform +2px (~15%) uplift across the whole type scale, preserving every density ratio:
app.css— allfont-sizevalues (base body 13px → 15px)fontSizeliterals in Surface keyboard shortcuts and cap label overflow #35's kanban / issue-detail / route componentsAvatarMath.max(...),size * 0.5) left untouchedEvidence
Measured prod vs local: identical px (both 13px), only the font differed — confirming the smallness came from the IBM Plex swap, not a layout change. After the bump, served base = 15px, comfortably larger than prod's Geist 13px.