Add Electron desktop shell and automated GitHub releases#536
Add Electron desktop shell and automated GitHub releases#536fakechris wants to merge 13 commits into
Conversation
TURNKEYAI_REACT_ENGINE=inline becomes the escape hatch. Gate 0 proven: three consecutive single-process engine runs of the full 272-case suite pass in ~2s each; the historical full-run hang no longer reproduces. All gates green on the flipped default (typecheck, role-runtime full, react-engine, agent-core, parity:inline oracle).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an Electron-based desktop shell (packages/desktop) for the TurnkeyAI Control Center, along with supporting daemon proof utilities, health check endpoints, and build/release scripts. It also enhances the mission completion evaluator, goal slot coverage, and observability snapshots to better handle unverified dimensions, browser failure buckets, and various edge cases. Additionally, the LLM adapter now sanitizes leading reasoning blocks, and the react-engine defaults to the engine path. A critical issue was identified in continuation-controller.ts where the helper function sliceUtf8 is used without being imported, which will cause a runtime ReferenceError.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
| return sendCount - (currentRecorded ? 1 : 0) > 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
The helper function sliceUtf8 is used here but it is not imported from ../tool-protocol or defined locally in this file. This will cause a runtime ReferenceError when attempting to slice the session continuation label. Please import sliceUtf8 from ../tool-protocol.
| return sliceUtf8(label, 120); |
1 participant
What changed
desktop:releasehelper that pushes the branch and an annotateddesktop-v<version>tagWhy
TurnkeyAI needs to stay easy to debug through the existing web server while also being distributable as a macOS app without requiring an Apple Developer account. The release path should be repeatable from one explicit command and safe to rerun.
Validation