Fix GetString precision loss for large int64 values #150
+55
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GetStringnow correctly returns the original string value for large integers instead of converting to scientific notationProblem
GetStringwas converting large integer route values (likeInt64.MaxValue) to scientific notation, causing precision loss:Root Cause
The
IsFloatpattern was parsing all numeric-looking strings as float64 values. For integers with more than ~15 significant digits, this caused precision loss since float64 only has 15-16 digits of precision.Solution
Modified the
IsFloatpattern to not match integer strings with more than 15 significant digits. Such values now remain asRString, preserving the original value exactly.This doesn't break
GetInt64because it already handlesRStringvalues by parsing them directly viaStringParser.parseInt64.Test plan
Int64.MaxValue🤖 Generated with Claude Code.
I (the human, Michael) couldn't find any place in the contribution docs that was against this, I hope it's ok. (also: want to be transparent about our slow demise as working software devs)