Skip to content

chore: Prohibit dependencies on included modules from causing unexpected version changes#247

Merged
jason-famedly merged 1 commit intomasterfrom
tt/freeze-deps
Mar 27, 2026
Merged

chore: Prohibit dependencies on included modules from causing unexpected version changes#247
jason-famedly merged 1 commit intomasterfrom
tt/freeze-deps

Conversation

@FrenchGithubUser
Copy link
Copy Markdown
Member

No description provided.

@FrenchGithubUser FrenchGithubUser changed the title Tt/freeze deps freeze deps Mar 26, 2026
dependencies versions for their own dependencies

this might not always work but will at least make the docker build fail
completely instead of silently downgrading dependencies
@FrenchGithubUser FrenchGithubUser marked this pull request as ready for review March 26, 2026 16:58
@FrenchGithubUser FrenchGithubUser requested a review from a team as a code owner March 26, 2026 16:58
Copilot AI review requested due to automatic review settings March 26, 2026 16:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Famedly Synapse addon image build to better control Python dependency resolution by introducing a pip constraints file derived from the base image environment.

Changes:

  • Generate a constraints.txt via pip freeze during the image build.
  • Apply -c constraints.txt when installing Synapse addons so transitive dependencies are constrained to the base image set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.13%. Comparing base (24f1cc4) to head (97fa0b2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.01%     
==========================================
  Files         501      501              
  Lines       71549    71549              
  Branches    10751    10751              
==========================================
- Hits        57342    57339       -3     
- Misses      10947    10949       +2     
- Partials     3260     3261       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f1cc4...97fa0b2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jason-famedly jason-famedly changed the title freeze deps chore: Prohibit dependencies on included modules from causing unexpected version changes Mar 27, 2026
@jason-famedly jason-famedly added this pull request to the merge queue Mar 27, 2026
Merged via the queue into master with commit d0e3246 Mar 27, 2026
33 checks passed
@jason-famedly jason-famedly deleted the tt/freeze-deps branch March 27, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants