fix(again): Allow account deactivation even with disabled profile changes#249
Draft
jason-famedly wants to merge 3 commits intofamedly-release/v1.150from
Draft
fix(again): Allow account deactivation even with disabled profile changes#249jason-famedly wants to merge 3 commits intofamedly-release/v1.150from
jason-famedly wants to merge 3 commits intofamedly-release/v1.150from
Conversation
The 'deactivation' argument was removed from the profile handler setting methods. Will have to use another method Keeping the tests
And refactor a test helper that was mostly duplicated code
jason-famedly
force-pushed
the
jason/fixup-profile-deletion
branch
from
16a46b0 to
a720db9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by upstream changes. Same behavior as before, just adjust to be in a new function instead
Fixes: #248
Replaces #84