Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SQL builders for DROP INDEX, DROP TABLE, and DROP SCHEMA, including support for IF EXISTS and drop behavior (CASCADE / RESTRICT), plus snapshot tests to validate generated SQL.
Changes:
- Introduce
DropBehaviorenum to representCASCADE/RESTRICT. - Add new statement builders:
DropIndex,DropTable,DropSchema. - Add insta snapshot tests covering the generated DROP SQL.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pqb/tests/drop.rs | Adds snapshot tests validating DROP SQL generation. |
| pqb/src/types/mod.rs | Introduces DropBehavior shared by DROP statement builders. |
| pqb/src/table/mod.rs | Wires in the new table::drop module and re-exports it. |
| pqb/src/table/drop.rs | Implements DropTable builder and SQL writer. |
| pqb/src/schema/mod.rs | Introduces new schema module with drop support. |
| pqb/src/schema/drop.rs | Implements DropSchema builder and SQL writer. |
| pqb/src/lib.rs | Exposes the new schema module from the crate root. |
| pqb/src/index/mod.rs | Wires in the new index::drop module and re-exports it. |
| pqb/src/index/drop.rs | Implements DropIndex builder and SQL writer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.