Repository navigation
ci: fix clippy deprecation and the fuzz build on current toolchains - #602
Merged
Merged
Conversation
Rust 1.95+ deprecates AtomicUsize::fetch_update in favour of try_update, which fails clippy -D warnings on stable. Same semantics, new name. The release Dockerfile already builds with Rust 1.98.
fuzz/ is its own workspace with no lockfile, so every ClusterFuzzLite run resolved the newest crates. aws-lc-sys 0.45.0 compiles jitterentropy with -O3 under the sanitizer flags and fails the build. Seed the lockfile from the root one, which pins aws-lc-sys 0.42.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two checks fail on every PR right now, unrelated to the PR content (seen on #601):
check(clippy): stable deprecatesAtomicUsize::fetch_update; renamed totry_updateincrw-renderer. The release Dockerfile builds with Rust 1.98, so the new name is available there.fuzzing:fuzz/has no lockfile, so ClusterFuzzLite resolvedaws-lc-sys0.45.0, whose jitterentropy compile fails under the sanitizer flags (must not be compiled with optimizations). Commit afuzz/Cargo.lockseeded from the root lock (aws-lc-sys0.42.0).ref #600