Skip to content

Conversation

@segevfiner
Copy link

@segevfiner segevfiner commented Aug 7, 2025

Also partitioned cookies are only allowed with secure, so in secure: 'auto' also set partitioned to false

Checklist

@ilteoood
Copy link

hey @segevfiner , are you planning to continue on this one?

@segevfiner
Copy link
Author

Need to merge/rebase and see if I can figure out the tests bit. I don't remember what didn't work for me with the tests when I originally tried doing this.

Also partitioned cookies are only allowed with secure, so in `secure: 'auto'` also set partitioned to false
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking to review it

@Eomm Eomm self-requested a review November 26, 2025 17:23
Copy link
Author

@segevfiner segevfiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to fix that tests. Seems there was an implicit assumption about localhost being insecure in some of the tests, so I tried to work around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants