fix(web): strip auth search params from URL after callback redirect#4088
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix(web): strip auth search params from URL after callback redirect#4088devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After OAuth/OTP login, the auth callback URL's query params (
code,token_hash,flow, etc.) were leaking into the redirected URL instead of being stripped. This adds explicitsearch: {}to allthrow redirect()calls in the callback route'sbeforeLoad, and addsreplace: trueto the component-levelnavigate()fallback.Changes:
throw redirect()calls for web flow inbeforeLoadnow passsearch: {}to explicitly clear search paramsuseEffectfallbacknavigate()now usesreplace: trueto replace the callback URL in historyReview & Testing Checklist for Human
flow=web: Log in, go through callback, and verify the final URL at/app/account/has no leftovercode/flow/schemeparams. This is the primary bug being fixed and was not tested live.navigate()fallback also strips params: TheuseEffectnavigatecall gotreplace: truebut notably does NOT includesearch: {}like thebeforeLoadredirects do. If thebeforeLoadredirect fails to fire (known TanStack Start SSR issue #3462), the component fallback may still leak params. Consider whethersearch: {}should be added to thenavigatecall too./update-password/redirects were also updated — verify password reset via email still works end-to-end.Notes