Skip to content

Comments

fix: remove min/max constraints from slop-check schema numbers#4098

Merged
goranmoomin merged 1 commit intomainfrom
devin/1771506274-fix-slop-check-schema
Feb 19, 2026
Merged

fix: remove min/max constraints from slop-check schema numbers#4098
goranmoomin merged 1 commit intomainfrom
devin/1771506274-fix-slop-check-schema

Conversation

@devin-ai-integration
Copy link
Contributor

fix: remove min/max constraints from slop-check schema numbers

Summary

The slop-check script added in #4084 uses z.number().min(1).max(10) for score fields in the Zod schema passed to generateObject. When converted to JSON Schema for Anthropic's structured output API, this produces minimum/maximum properties on the number type, which Anthropic does not support — causing the error seen in #4097:

Error: output_format.schema: For 'number' type, properties maximum, minimum are not supported

This fix removes .min()/.max() and moves the range guidance into the .describe() string (e.g. "Score from 1 to 10: ..."), which the model will still follow without producing unsupported schema properties.

Review & Testing Checklist for Human

  • Verify the fix resolves the error: Trigger the blog-check workflow on a blog/* PR (or re-run the check on Publish: The 5 Meeting Productivity Tools Worth Using in 2026 #4097) and confirm the slop check no longer errors out
  • Spot-check returned scores are in range: Since the 1-10 constraint is now a soft hint in the description string rather than schema-enforced, confirm the model returns reasonable scores (the totalScore >= 35 threshold at line 358 still assumes scores are 1-10)

Notes

Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 0250617
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/69970ab1f98ad200089fa5e0

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 0250617
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69970ab1f5c8600008b5dea7

@goranmoomin goranmoomin merged commit 41a58c4 into main Feb 19, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant