fix: remove min/max constraints from slop-check schema numbers#4098
Merged
goranmoomin merged 1 commit intomainfrom Feb 19, 2026
Merged
fix: remove min/max constraints from slop-check schema numbers#4098goranmoomin merged 1 commit intomainfrom
goranmoomin merged 1 commit intomainfrom
Conversation
Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove min/max constraints from slop-check schema numbers
Summary
The slop-check script added in #4084 uses
z.number().min(1).max(10)for score fields in the Zod schema passed togenerateObject. When converted to JSON Schema for Anthropic's structured output API, this producesminimum/maximumproperties on thenumbertype, which Anthropic does not support — causing the error seen in #4097:This fix removes
.min()/.max()and moves the range guidance into the.describe()string (e.g."Score from 1 to 10: ..."), which the model will still follow without producing unsupported schema properties.Review & Testing Checklist for Human
blog/*PR (or re-run the check on Publish: The 5 Meeting Productivity Tools Worth Using in 2026 #4097) and confirm the slop check no longer errors outtotalScore >= 35threshold at line 358 still assumes scores are 1-10)Notes