Skip to content

Fix instantiation failure with wazero >= v1.12 (cross-runtime CompiledModule reuse) #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elkhantar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix instantiation failure with wazero >= v1.12 (cross-runtime CompiledModule reuse) #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,30 @@ func New(options ...Option) (runtime *Runtime, err error) {
return nil, fmt.Errorf("failed to setup host module: %w", err)
}

// Compile on this runtime rather than reusing the globally compiled
// module: CompileModule bakes the compiling Runtime's store-assigned
// function type IDs into the CompiledModule, and since wazero v1.12
// import resolution compares those numeric IDs (needed for the GC
// proposal's concrete ref types) instead of structural signatures.
// Instantiating a module compiled on another Runtime therefore fails
// with "signature mismatch" on identical-looking signatures. The
// machine code is shared through the CompilationCache held in
// cachedRuntimeConfig, so this per-runtime compile is a cache hit.
qjsBytes := wasmBytes
if len(option.QuickJSWasmBytes) > 0 {
qjsBytes = option.QuickJSWasmBytes
}
localCompiled, err := runtime.wrt.CompileModule(option.Context, qjsBytes)
if err != nil {
return nil, fmt.Errorf("failed to compile qjs module: %w", err)
}

fsConfig := wazero.
NewFSConfig().
WithDirMount(runtime.option.CWD, "/")
if runtime.module, err = runtime.wrt.InstantiateModule(
option.Context,
compiledQJSModule,
localCompiled,
wazero.NewModuleConfig().
WithStartFunctions(option.StartFunctionName).
WithSysWalltime().
Expand Down