Skip to content

Fix misplaced super.ready call #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NonSwag merged 1 commit into from
Jun 17, 2026
Merged

Fix misplaced super.ready call #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bukkit/src/main/java/dev/faststats/bukkit/BukkitContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@ protected BukkitMetrics.Factory metricsFactory() {

@Override
public void ready() {
super.ready();
if (!ready) try {
Class.forName("com.destroystokyo.paper.event.server.ServerExceptionEvent");
plugin.getServer().getPluginManager().registerEvents(new PaperEventListener(plugin, this), plugin);
} catch (final ClassNotFoundException ignored) {
} finally {
super.ready();
}
}

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version=0.26.1
version=0.26.2
org.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m
2 changes: 1 addition & 1 deletion minestom/src/main/java/dev/faststats/minestom/MinestomContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ public final class MinestomContext extends SimpleContext {

@Override
public void ready() {
super.ready();
if (!ready) errorTrackerService().map(ErrorTrackerService::globalErrorTracker).ifPresent(errorTracker -> {
final var handler = MinecraftServer.getExceptionManager().getExceptionHandler();
MinecraftServer.getExceptionManager().setExceptionHandler(error -> {
Expand All @@ -39,6 +38,7 @@ public void ready() {
errorTracker.trackError(error);
});
});
super.ready();
}

@Override
Expand Down