Handle paginated API - #5
Open
kousu wants to merge 3 commits into
Open
Conversation
added 2 commits
June 1, 2018 20:46
Without this, a large DO account will randomly break get_record(), because get_record() only looked at the first page, before, and then it would just create a new record from scratch, potentially leaving you with hundreds of duplicate A records in your account (which just makes the account even larger!). json_value had to go because its awk program was too simple to handle the recursiveness of json; in particular, : is a delimiter in json, but it's also a delimiter in URLs, so getting the next page's URL would break. I replaced it, and awk, with a new dependency on https://stedolan.github.io/jq/, which is unfortunate but necessary. There's no way to correctly parse javascript in a bash one-liner.
I regularly observed DO's API giving me more than 50 results per page, so instead of guessing at what the count should be if we don't receive it, skip the entire page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, a large DO account will randomly break get_record(),
because get_record() only looked at the first page, before, and
then it would just create a new record from scratch, potentially
leaving you with hundreds of duplicate A records in your account
(which just makes the account even larger!).
json_value had to go because its awk program was too simple to handle
the recursiveness of json; in particular, : is a delimiter in json,
but it's also a delimiter in URLs, so getting the next page's URL
would break. I replaced it, and awk, with a new dependency on
https://stedolan.github.io/jq/, which is unfortunate but necessary.
There's no way to correctly parse javascript in a bash one-liner.