Add Windows build support#1
Merged
Merged
Conversation
- Switch build job runner from ubuntu-latest to windows-latest so the net8.0-windows TFM (needed for Radarr.Windows.dll) can be compiled - Uncomment win-x64/win-x86 PackageTests and Package calls in build.sh - Publish win-x64 test artifact and build_windows artifact from build job - Download Windows artifact in release job and zip it alongside Linux tarballs - Include windows-core-x64/x86 zips in GitHub release upload Linux tarballs and Docker image are unaffected; .NET 8 cross-compiles all Linux RIDs from the Windows runner identically to before. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4.15.1 has a known moderate severity vulnerability (GHSA-9j88-vvj5-vhgr) which fails the build because TreatWarningsAsErrors=true promotes NU1902 to a hard error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latesttowindows-latestso thenet8.0-windowsTFM (required forRadarr.Windows.dll) can be compiledwin-x64/win-x86packaging lines inbuild.shthat were previously disabledbuild_windowsartifact from the build jobwindows-core-x64.zip/windows-core-x86.zipalongside the existing Linux tarballsNo impact on Linux/Docker users
.NET 8 cross-compiles all Linux RIDs from the Windows runner identically to before. The Docker build job and Linux tarballs are unchanged.
Test plan
windows-latestbuild_windowsartifact is produced and containswin-x64andwin-x86foldersbuild_linuxartifact still contains all Linux RIDsdevelop, confirm the release includes.windows-core-x64.zipand.windows-core-x86.zipGenerated with Claude Code