fix(sessions): discard stale search results on query change (#387)#407
Open
simplast wants to merge 1 commit into
Open
fix(sessions): discard stale search results on query change (#387)#407simplast wants to merge 1 commit into
simplast wants to merge 1 commit into
Conversation
Track the active query with a ref and settledQuery so in-flight searchSessions promises cannot repopulate or display results for a previous search. Refactor Sessions content rendering into explicit view states for easier debugging. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale session search results in Sessions view (#387)
In-flight searchSessions calls could resolve after the user changed or cleared the query, writing outdated results back into state and leaving previous search cards visible.
This fix:
Tracks the active query with a ref and ignores stale async responses
Introduces settledQuery so results render only when they match the current input
Clears search state synchronously on input change
Refactors content rendering into explicit view states
Adds regression tests for clear, query switch, and late-resolve races
Fixes #387