Skip to content

Improve zh-TW Traditional Chinese locale#534

Open
PeterDaveHello wants to merge 1 commit into
fathah:mainfrom
PeterDaveHelloKitchen:zh-TW
Open

Improve zh-TW Traditional Chinese locale#534
PeterDaveHello wants to merge 1 commit into
fathah:mainfrom
PeterDaveHelloKitchen:zh-TW

Conversation

@PeterDaveHello

Copy link
Copy Markdown

This pull request updates and improves the Traditional Chinese (zh-TW) translations across multiple UI modules, focusing on terminology consistency, clarity, and naturalness. The most significant changes include standardizing the translation for "gateway" to "閘道", refining terms related to agents, context, and kanban features, and enhancing the accuracy of prompts and descriptions throughout the UI.

These changes collectively improve the overall user experience for Traditional Chinese users by making the UI more intuitive, consistent, and professional.

@pmos69

pmos69 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Thanks, this looks like a useful zh-TW polish pass. The terminology and typography changes look directionally good to me.

The PR is currently stale against main and has conflicts in:

  • src/shared/i18n/locales/zh-TW/chat.ts
  • src/shared/i18n/locales/zh-TW/skills.ts

Could you please rebase/update the branch against current main and resolve those conflicts?

When resolving, please make sure to preserve the newer keys that already exist on main, especially searchModels, queuedCancel, uninstallConfirm, and uninstallSuccess. It would also be great to translate uninstallConfirm / uninstallSuccess while touching skills.ts, since they are still English in the current zh-TW locale.

After that, this should be much easier to merge.

@PeterDaveHello

Copy link
Copy Markdown
Author

Thanks, this looks like a useful zh-TW polish pass. The terminology and typography changes look directionally good to me.

The PR is currently stale against main and has conflicts in:

  • src/shared/i18n/locales/zh-TW/chat.ts
  • src/shared/i18n/locales/zh-TW/skills.ts

Could you please rebase/update the branch against current main and resolve those conflicts?

When resolving, please make sure to preserve the newer keys that already exist on main, especially searchModels, queuedCancel, uninstallConfirm, and uninstallSuccess. It would also be great to translate uninstallConfirm / uninstallSuccess while touching skills.ts, since they are still English in the current zh-TW locale.

After that, this should be much easier to merge.

Sure

@PeterDaveHello

Copy link
Copy Markdown
Author

@pmos69, PR updated. Thanks!

@greptile-apps

greptile-apps Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR comprehensively improves the Traditional Chinese (zh-TW) locale across all 23 translation files, standardizing terminology (網關→閘道, 上下文→脈絡, 代理→Agent, 生成→產生), replacing ASCII ellipses (...) with the proper Unicode character (), and adding translations for many newly introduced UI features.

  • Fixes two previously untranslated English strings in skills.ts (uninstallConfirm, uninstallSuccess) that would have displayed raw English to zh-TW users.
  • Adds two new locale files (diagnose.ts, discover.ts) and registers them in index.ts; diagnose.ts is missing the as const assertion used by every other locale file in the project.
  • Removes second-person pronouns ("你的"/"您的") throughout for a more neutral, professional tone consistent with Traditional Chinese UI conventions.

Confidence Score: 4/5

Safe to merge — all changes are locale strings with no logic or runtime-path modifications.

The translation improvements are thorough and consistent across all 23 files. The only structural issue is that the new diagnose.ts file omits the as const assertion that every other locale file in the project uses, which loses TypeScript literal-type inference for that module's strings.

src/shared/i18n/locales/zh-TW/diagnose.ts — missing as const.

Important Files Changed

Filename Overview
src/shared/i18n/index.ts Adds import and registration of two new zh-TW locale modules (discoverZhTw, diagnoseZhTw) into the resources map. Changes are mechanical and correct.
src/shared/i18n/locales/zh-TW/diagnose.ts New locale file for the health/diagnostic UI. Well-translated, but missing the as const assertion used by every other locale file in the codebase.
src/shared/i18n/locales/zh-TW/discover.ts New locale file for the community discover/browse tab. Well-translated with as const correctly applied.
src/shared/i18n/locales/zh-TW/skills.ts Fixes two untranslated English strings (uninstallConfirm, uninstallSuccess); also improves punctuation and wording throughout.
src/shared/i18n/locales/zh-TW/tools.ts Large expansion adding full MCP server management UI strings, new tool entries (x_search, computer_use, video_gen), and improved terminology.
src/shared/i18n/locales/zh-TW/settings.ts Significant expansion covering SSH tunnel mode, community Discord section, model discovery UI, and various text refinements.
src/shared/i18n/locales/zh-TW/gateway.ts Large expansion with platform config UI keys and API server key management; standardizes 網關→閘道 throughout.
src/shared/i18n/locales/zh-TW/chat.ts Large expansion adding reasoning effort levels, clarify dialog, attachment handling; replaces 上下文 with 脈絡 consistently.
src/shared/i18n/locales/zh-TW/kanban.ts Terminology improvements: 派發→分派, 代理→Agent, 分類→待分類, and new tooltip keys.
src/shared/i18n/locales/zh-TW/constants.ts Adds translations for new providers and auxiliary task section; refines existing platform descriptions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[index.ts] -->|imports & registers| B[discoverZhTw\nnew file]
    A -->|imports & registers| C[diagnoseZhTw\nnew file missing as const]
    A -->|already registered| D[Existing zh-TW modules\n21 files updated]
    D --> D1[agents / chat / common\nnavigation / kanban]
    D --> D2[gateway / settings / tools\nconstants / models]
    D --> D3[memory / office / sessions\nskills / soul / etc.]
Loading

Reviews (1): Last reviewed commit: "Improve zh-TW Traditional Chinese locale" | Re-trigger Greptile

Comment on lines +27 to +33
fix: {
apply: "套用修正",
running: "套用中…",
success: "已套用修正。",
failure: "修正失敗。",
},
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing as const assertion — every other zh-TW locale file (and every other locale file in the codebase) ends with } as const. Without it, TypeScript infers each string value as string rather than its literal type, which weakens type-checking for the keys in this module and is inconsistent with the established pattern.

Suggested change
fix: {
apply: "套用修正",
running: "套用中…",
success: "已套用修正。",
failure: "修正失敗。",
},
};
fix: {
apply: "套用修正",
running: "套用中…",
success: "已套用修正。",
failure: "修正失敗。",
},
} as const;

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take at look at it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants