Improve zh-TW Traditional Chinese locale#534
Conversation
|
Thanks, this looks like a useful zh-TW polish pass. The terminology and typography changes look directionally good to me. The PR is currently stale against
Could you please rebase/update the branch against current When resolving, please make sure to preserve the newer keys that already exist on After that, this should be much easier to merge. |
Sure |
|
@pmos69, PR updated. Thanks! |
Greptile SummaryThis PR comprehensively improves the Traditional Chinese (zh-TW) locale across all 23 translation files, standardizing terminology (網關→閘道, 上下文→脈絡, 代理→Agent, 生成→產生), replacing ASCII ellipses (
Confidence Score: 4/5Safe to merge — all changes are locale strings with no logic or runtime-path modifications. The translation improvements are thorough and consistent across all 23 files. The only structural issue is that the new diagnose.ts file omits the as const assertion that every other locale file in the project uses, which loses TypeScript literal-type inference for that module's strings. src/shared/i18n/locales/zh-TW/diagnose.ts — missing as const. Important Files Changed
|
| fix: { | ||
| apply: "套用修正", | ||
| running: "套用中…", | ||
| success: "已套用修正。", | ||
| failure: "修正失敗。", | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Missing
as const assertion — every other zh-TW locale file (and every other locale file in the codebase) ends with } as const. Without it, TypeScript infers each string value as string rather than its literal type, which weakens type-checking for the keys in this module and is inconsistent with the established pattern.
| fix: { | |
| apply: "套用修正", | |
| running: "套用中…", | |
| success: "已套用修正。", | |
| failure: "修正失敗。", | |
| }, | |
| }; | |
| fix: { | |
| apply: "套用修正", | |
| running: "套用中…", | |
| success: "已套用修正。", | |
| failure: "修正失敗。", | |
| }, | |
| } as const; |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
I will take at look at it soon.
This pull request updates and improves the Traditional Chinese (zh-TW) translations across multiple UI modules, focusing on terminology consistency, clarity, and naturalness. The most significant changes include standardizing the translation for "gateway" to "閘道", refining terms related to agents, context, and kanban features, and enhancing the accuracy of prompts and descriptions throughout the UI.
These changes collectively improve the overall user experience for Traditional Chinese users by making the UI more intuitive, consistent, and professional.