Fix/skills test waitfor

[parvezmosharafbd]

No description provided.

[greptile-apps]

Greptile Summary

This PR fixes a flaky test in Skills.test.tsx by wrapping tab-selection DOM queries in waitFor, ensuring the component is fully rendered before assertions run. It also bumps several dependencies (vite to ^7.3.3, package version to 0.5.4) and regenerates the lock file.

• Test fix: The first test case is correctly updated — querySelectorAll is moved inside waitFor and the browseTab variable is assigned once with a strong HTMLButtonElement type. The second test case has the same fix applied but the original assignment was not removed, leaving a duplicate (dead) reassignment inside the same waitFor block.
• Dependencies: Routine patch/minor bumps across vite, brace-expansion, lodash, nanoid, postcss, ip-address, and others in the lock file.
• Other files: Several unrelated files are included in the PR — a machine-specific Python venv, placeholder GitHub workflow files, an unfilled SECURITY.md template, and VS Code debug configs in tests/.

Confidence Score: 5/5

The core test fix is safe and functionally correct; the duplicate assignment in the second test is dead code that does not affect test behavior or results.

The test changes are narrow and low-risk — both test cases still select the correct DOM element and assertions pass. The duplicate browseTab assignment in the second test is inert dead code. Dependency bumps are routine patch/minor updates.

src/renderer/src/screens/Skills/Skills.test.tsx — second test waitFor block has a leftover duplicate assignment that should be cleaned up.

Important Files Changed

Filename	Overview
src/renderer/src/screens/Skills/Skills.test.tsx	Wraps tab-selection in waitFor for both tests; first test is clean but second test has a duplicate browseTab assignment (dead code left over from an incomplete edit).
package.json	Version bumped to 0.5.4 and vite updated from ^7.2.6 to ^7.3.3; routine dependency update.
package-lock.json	Lock file regenerated to match package.json bumps; multiple transitive dependency versions updated (brace-expansion, lodash, nanoid, postcss, vite, etc.).
tests/.venv/pyvenv.cfg	Machine-specific virtual environment config with hardcoded absolute codespace path; should not be committed (already flagged in a previous review thread).
.github/workflows/webpack.yml	Workflow only installs system dependencies and never runs a build; provides no CI value (already flagged in a previous review thread).
.github/workflows/generator-generic-ossf-slsa3-publish.yml	SLSA workflow with unmodified template placeholder build steps producing dummy artifacts (already flagged in a previous review thread).
.github/workflows/datadog-synthetics.yml	Datadog Synthetics CI workflow; uses secrets references for API keys but the keys issue was already flagged in a prior review thread.
SECURITY.md	Unedited GitHub template SECURITY.md with placeholder version numbers (5.1.x/4.0.x) and generic text that does not reflect the actual project's version history or contact information.
tests/.vscode/launch.json	VS Code debug launch configuration for the tests directory; project-specific IDE config committed alongside the venv files.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[render Skills component] --> B[waitFor: API calls fired]
    B --> C{waitFor: Browse tab exists?}
    C -- yes --> D[fireEvent.click browseTab]
    C -- retry --> C
    D --> E{waitFor: Install button exists?}
    E -- yes --> F[fireEvent.click installBtn]
    E -- retry --> E
    F --> G1[Test 1: installSkill called with correct args]
    F --> G2[Test 2: skills-error banner shown with CLI message]

Loading

_{Reviews (3): Last reviewed commit: "Merge branch 'main' into fix/skills-test..." | Re-trigger Greptile}

[parvezmosharafbd]

thanks, and always fix upcoming issues.

[pmos69]

Thanks for tracking down the flaky Skills test. I agree with the core idea here: the first Browse tab lookup should wait for the async render before clicking it.

I don't think we can merge this branch as-is, though. It is now conflicting with current main, and it includes a lot of unrelated files: GitHub workflow templates, stock SECURITY.md, tests/.venv, tests/.vscode, plus dependency/lockfile changes.

Could you please re-cut this as a tiny PR against current main that only changes src/renderer/src/screens/Skills/Skills.test.tsx?

For that version:

• keep the waitFor around the first Browse tab lookup
• remove the duplicate browseTab assignment in the second test
• drop the temporary "FIX" comment/emoji
• remove the workflow/security/venv/IDE/dependency files

That should make the actual test fix straightforward to review and merge.