Skip to content

Merge pull request #5 from fathah/main#573

Open
parvezmosharafbd wants to merge 7 commits into
fathah:mainfrom
parvezmosharafbd:main
Open

Merge pull request #5 from fathah/main#573
parvezmosharafbd wants to merge 7 commits into
fathah:mainfrom
parvezmosharafbd:main

Conversation

@parvezmosharafbd

Copy link
Copy Markdown

Fix host-derived API key handling for custom providers

dependabot Bot and others added 4 commits June 4, 2026 23:15
Bumps the npm_and_yarn group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `7.3.1` | `7.3.2` |
| [@xmldom/xmldom](https://github.com/xmldom/xmldom) | `0.8.12` | `0.8.13` |
| [ip-address](https://github.com/beaugunderson/ip-address) | `10.1.0` | `10.2.0` |
| [lodash](https://github.com/lodash/lodash) | `4.17.21` | `4.18.1` |
| [postcss](https://github.com/postcss/postcss) | `8.5.8` | `8.5.15` |
| [tmp](https://github.com/raszi/node-tmp) | `0.2.5` | `0.2.7` |



Updates `vite` from 7.3.1 to 7.3.2
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v7.3.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.3.2/packages/vite)

Updates `@xmldom/xmldom` from 0.8.12 to 0.8.13
- [Release notes](https://github.com/xmldom/xmldom/releases)
- [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md)
- [Commits](xmldom/xmldom@0.8.12...0.8.13)

Updates `ip-address` from 10.1.0 to 10.2.0
- [Commits](beaugunderson/ip-address@v10.1.0...v10.2.0)

Updates `lodash` from 4.17.21 to 4.18.1
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.18.1)

Updates `postcss` from 8.5.8 to 8.5.15
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.5.8...8.5.15)

Updates `tmp` from 0.2.5 to 0.2.7
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.3.2
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: "@xmldom/xmldom"
  dependency-version: 0.8.13
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: ip-address
  dependency-version: 10.2.0
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: lodash
  dependency-version: 4.18.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: postcss
  dependency-version: 8.5.15
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Fix host-derived API key handling for custom providers
…pm_and_yarn-5f313d0922

Bump the npm_and_yarn group across 1 directory with 6 updates
Added a security policy document outlining supported versions and vulnerability reporting.
@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps vite from ^7.2.6 to ^7.3.2 and adds a SECURITY.md policy file; the package-lock.json is regenerated with patch/minor bumps to several transitive dependencies (brace-expansion, lodash, nanoid, postcss, ip-address, tmp, @xmldom/xmldom).

  • package.json / package-lock.json: routine dependency refresh with no production code changes; transitive peer flags removed from several entries (ajv, rollup, @types/node, macos-alias) as those packages moved from peer-only to direct resolution.
  • SECURITY.md: file added using the unmodified GitHub template — the version support table and vulnerability-reporting section still contain placeholder text that does not reflect this project.

Confidence Score: 5/5

Safe to merge — all changes are dependency version bumps with no production logic modifications.

The only application-facing change is a Vite dev-dependency bump; all other changes are transitive lock-file updates and a new SECURITY.md. None of these touch runtime code paths.

SECURITY.md — contains uncustomized template placeholder content that should be updated before it misleads security researchers.

Important Files Changed

Filename Overview
SECURITY.md New SECURITY.md added using the unmodified GitHub template — version table and reporting instructions are all placeholder text unrelated to the actual project.
package.json Single change: vite dev dependency bumped from ^7.2.6 to ^7.3.2.
package-lock.json Lock file regenerated to reflect vite 7.3.2 and upstream patch/minor bumps to brace-expansion, lodash, nanoid, postcss, ip-address, tmp, @xmldom/xmldom; several entries also had the peer flag removed as they transitioned to direct dependencies.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #573 Changes] --> B[package.json]
    A --> C[package-lock.json]
    A --> D[SECURITY.md]

    B --> B1[vite ^7.2.6 → ^7.3.2]

    C --> C1[vite 7.3.1 → 7.3.2]
    C --> C2[brace-expansion 1.x: 1.1.13 → 1.1.15]
    C --> C3[brace-expansion 2.x: 2.0.3 → 2.1.1]
    C --> C4[brace-expansion 5.x: 5.0.5 → 5.0.6]
    C --> C5[lodash 4.17.21 → 4.18.1]
    C --> C6[nanoid 3.3.11 → 3.3.12]
    C --> C7[postcss 8.5.8 → 8.5.15]
    C --> C8[ip-address 10.1.0 → 10.2.0]
    C --> C9[tmp 0.2.5 → 0.2.7]
    C --> C10[peer flag removed: ajv, rollup, @types/node]

    D --> D1[⚠️ Unmodified GitHub template]
    D1 --> D2[Placeholder version table]
    D1 --> D3[Placeholder reporting instructions]
Loading

Reviews (4): Last reviewed commit: "Merge branch 'fathah:main' into main" | Re-trigger Greptile

Comment thread package.json
@pmos69

pmos69 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR. I don’t think we can merge this as-is.

The PR title/body say this fixes host-derived API key handling for custom providers, but the diff does not touch that area. It only updates dependency lockfile entries and adds a SECURITY.md.

Also, the new SECURITY.md is still the stock template text and includes unsupported/incorrect version claims (5.1.x, 5.0.x, 4.0.x, etc.), while this project is currently on the 0.5.x line. We should not publish placeholder security-policy text because it gives users incorrect vulnerability-reporting and support information.

Could you please reopen this as a clean topic branch rebased on current main, with one focused change only?

  • If this is meant to be a dependency update, please remove SECURITY.md and let CI run on the clean dependency diff.
  • If this is meant to add a security policy, please make the policy project-specific and remove the dependency bump.
  • If this is meant to fix custom-provider API key handling, please include the actual source changes for that fix.

@pmos69

pmos69 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

I rechecked this against current main now that #665 and the later merges have landed.

The good news is that the actual merge result is small and does not touch the recent runtime/SSH/dashboard code. It only adds SECURITY.md, bumps the Vite spec, and updates the lockfile for Vite/transitive packages.

I still don’t think we should merge it as-is, though. The SECURITY.md is still the stock GitHub template, including placeholder supported versions like 5.1.x, 5.0.x, and 4.0.x, plus placeholder vulnerability-reporting text. Publishing that would be misleading for this project.

Could you please split/clean this up?

  • If the goal is the dependency bump, please remove SECURITY.md and keep this as a clean dependency-only PR.
  • If the goal is adding a security policy, please make it project-specific and remove the dependency bump.

The dependency bump itself looks mechanically fine; the blocker is the mixed scope plus the placeholder security policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants