feat: add Korean (ko) localization#582
Conversation
- Add 24 Korean locale files in src/shared/i18n/locales/ko/ - Add 'ko' to config.ts APP_LOCALES and types.ts AppLocale - Add Korean language option to Settings.tsx LANGUAGE_NATIVE_NAMES - Add README-KO.md (Korean README) - Add PLAN.md, Test.md, and phase1-5.md progress tracking files
Greptile SummaryThis PR adds a full Korean (
Confidence Score: 3/5Not safe to merge as-is — selecting Korean in the UI will silently display English for every string The 24 Korean translation files are well-written and complete, and the type/config/UI wiring is correct. But the locale registration step in index.ts was skipped entirely, meaning no Korean string will ever reach the user. Additionally, several planning documents are committed to the repo root. src/shared/i18n/index.ts needs ~25 import statements and a ko resources block added, matching the pattern used by every other locale Important Files Changed
|
| @@ -0,0 +1,65 @@ | |||
| # hermes-desktop 한국어 현지화 계획 | |||
There was a problem hiding this comment.
Development process files committed to repository
PLAN.md, Test.md, phase1.md–phase5.md appear to be personal planning and progress-tracking documents for this PR. Committing them to the repo root adds noise to the project history and may confuse future contributors. Consider removing them before merging, or moving them out of the repo entirely.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
yep. my mistake. I will make it removed before merging.
변경 사항
테스트 결과