Bug fixes#45
Merged
Merged
Conversation
Contributor
charliewang123
commented
Mar 15, 2026
- Updated README examples to use data_generator_direct and data_generator_direct_indirect with correct dataset object names, as well as fix issues with depth parameter and implemented set.seed() for reproducibility
- Fixed output = "detection" -> "estimation" and updated plot_NCT call in Example 2
- Deleted duplicate nct_algorithm.png (lowercase) to fix R CMD check error
Removed the figure caption for the Network Causal Tree algorithm image.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes several issues in the README examples and removes a duplicate image file that was causing R CMD check errors. The examples now use the correct function names, dataset variable names, and parameter values consistent with the actual package API.
Changes:
- Updated README examples to use
data_generator_direct(Example 1) anddata_generator_direct_indirect(Example 2) with matching dataset variable names, correcteddepthandoutputparameters, and addedset.seed(123)for reproducibility - Fixed Example 2's
plot_NCTcall to useeffect_color_nodesparameter and updated the title expression - Deleted duplicate lowercase
nct_algorithm.pngto resolve R CMD check errors, keeping onlyNCT_algorithm.png
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Corrected function names, variable names, parameters (depth, output), added set.seed(), and updated plot_NCT call in Example 2 |
| paper/images/NCT_algorithm.png | Added the properly-cased image file |
| paper/images/nct_algorithm.png | Deleted duplicate lowercase image file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.