Skip to content

Bug fixes#45

Merged
fbargaglistoffi merged 4 commits into
fbargaglistoffi:masterfrom
charliewang123:master
Mar 15, 2026
Merged

Bug fixes#45
fbargaglistoffi merged 4 commits into
fbargaglistoffi:masterfrom
charliewang123:master

Conversation

@charliewang123
Copy link
Copy Markdown
Contributor

  • Updated README examples to use data_generator_direct and data_generator_direct_indirect with correct dataset object names, as well as fix issues with depth parameter and implemented set.seed() for reproducibility
  • Fixed output = "detection" -> "estimation" and updated plot_NCT call in Example 2
  • Deleted duplicate nct_algorithm.png (lowercase) to fix R CMD check error

Copilot AI review requested due to automatic review settings March 15, 2026 19:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes several issues in the README examples and removes a duplicate image file that was causing R CMD check errors. The examples now use the correct function names, dataset variable names, and parameter values consistent with the actual package API.

Changes:

  • Updated README examples to use data_generator_direct (Example 1) and data_generator_direct_indirect (Example 2) with matching dataset variable names, corrected depth and output parameters, and added set.seed(123) for reproducibility
  • Fixed Example 2's plot_NCT call to use effect_color_nodes parameter and updated the title expression
  • Deleted duplicate lowercase nct_algorithm.png to resolve R CMD check errors, keeping only NCT_algorithm.png

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
README.md Corrected function names, variable names, parameters (depth, output), added set.seed(), and updated plot_NCT call in Example 2
paper/images/NCT_algorithm.png Added the properly-cased image file
paper/images/nct_algorithm.png Deleted duplicate lowercase image file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@fbargaglistoffi fbargaglistoffi merged commit 4e3f892 into fbargaglistoffi:master Mar 15, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants