Skip to content

Ability to disable log with level ERROR if key not exists #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roman-struchev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ability to disable log with level ERROR if key not exists #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions client-java-core/src/main/java/io/featurehub/client/ClientFeatureRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public class ClientFeatureRepository extends AbstractFeatureRepository
private ObjectMapper jsonConfigObjectMapper;
private final ApplyFeature applyFeature;
private boolean serverEvaluation = false; // the client tells us, we pass it out to others
private boolean logErrorIfKeyNotDefined = true; // log message with level ERROR if key is not defined

private final TypeReference<List<io.featurehub.sse.model.FeatureState>> FEATURE_LIST_TYPEDEF =
new TypeReference<List<io.featurehub.sse.model.FeatureState>>() {};
Expand All @@ -56,6 +57,11 @@ public ClientFeatureRepository(int threadPoolSize) {
this(getExecutor(threadPoolSize), null);
}

public ClientFeatureRepository(int threadPoolSize, boolean logErrorIfKeyNotDefined) {
this(threadPoolSize);
this.logErrorIfKeyNotDefined = logErrorIfKeyNotDefined;
}

public ClientFeatureRepository() {
this(1);
}
Expand Down Expand Up @@ -248,13 +254,11 @@ public FeatureState getFeatureState(String key) {
return features.computeIfAbsent(
key,
key1 -> {
if (hasReceivedInitialState) {
log.error(
"FeatureHub error: application requesting use of invalid key after initialization: `{}`",
key1);
if (hasReceivedInitialState && logErrorIfKeyNotDefined) {
log.error("FeatureHub error: application is requesting to use not defined key after initialization: `{}`", key1);
}

return new FeatureStateBase(null, this, key);
return new FeatureStateBase(null, this, key1);
});
}

Expand Down
4 changes: 3 additions & 1 deletion examples/todo-java/src/main/java/todo/backend/FeatureHubSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ public class FeatureHubSource implements FeatureHub {
String analyticsCid = "";
@ConfigKey("feature-service.sdk")
String clientSdk = "jersey3";
@ConfigKey("feature-service.logs.error-if-key-not-defined")
boolean logErrorIfKeyNotDefined = true;

private final FeatureRepositoryContext repository;
private final EdgeFeatureHubConfig config;
Expand All @@ -39,7 +41,7 @@ public FeatureHubSource() {

config = new EdgeFeatureHubConfig(featureHubUrl, sdkKey);

repository = new ClientFeatureRepository(5);
repository = new ClientFeatureRepository(5, logErrorIfKeyNotDefined);
repository.registerValueInterceptor(true, new SystemPropertyValueInterceptor());

if (analyticsCid.length() > 0 && analyticsKey.length() > 0) {
Expand Down