Skip to content

Feature/general sign up - #1

Open
fedasevich wants to merge 39 commits into
developfrom
feature/general-sign-up
Open

fedasevich wants to merge 39 commits into
developfrom
feature/general-sign-up

Conversation

@fedasevich

Copy link
Copy Markdown
Owner

Describe your changes

  • I did an awesome feature.

Issue ticket code (and/or) and link

  • Link to JIRA ticket

General

  • Assigned myself to the PR
  • Assigned the appropriate labels to the PR
  • Assigned the appropriate reviewers to the PR
  • Updated the documentation
  • Performed a self-review of my code
  • Types for input and output parameters
  • Don't have "any" on my code
  • Used the try/catch pattern for error handling
  • Don't have magic numbers
  • Compare only with constants not with strings
  • No ternary operator inside the ternary operator
  • Don't have commented code
  • no links in the code, env links should be in env file (for example: server url), constant links (for example default avatar URL) should be in constant file.
  • Used camelCase for variables and functions
  • Date and time formats are on the constants
  • Functions are public only if it's used outside the class
  • No hardcoded values
  • covered by tests
  • Check your commit messages meet the conventional commit format.

Frontend

  • Components and business logic are separated
  • Colors, Font Size, and Font Name is on the theme or in the constants
  • No text in the components, use i18n approach
  • No inline styles
  • Imports are absolute
  • Attach a screenshot if PR has visual changes.

Backend

  • Swagger documentation updated
  • Database requests are optimized and not redundant
  • Unit tests written
  • use ConfigService instead of process.env
  • use transactions if there is a call chain that mutates data in different tables
  • use @index decorator for frequently requested data

ProggerOleg and others added 30 commits November 15, 2023 20:37
…lidation, added defferent cases handling(no such user, already verified...)

This branch was successfully deployed

1 active deployment
Preview 22281eb9 Deployed Nov 22, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants