Skip to content

Conversation

@NateMoeller
Copy link
Contributor

  • Import contacts from follows on nostr via NIP-05 identifier or npub
  • Add contact by NIP-05 identifier or npub
  • View profile information with ability to pay contact
  • Search Contacts via name
  • Refresh/Delete contact

Add individual contact:
contacts_add_individual

Add contacts nostr follows:
contacts_import_follows

View profile
contacts_profile

@NateMoeller NateMoeller marked this pull request as draft January 24, 2026 23:08
@NateMoeller NateMoeller marked this pull request as ready for review January 25, 2026 23:17
- Import contacts from follows on nostr via NIP-05 identifier or npub
- Add contact by NIP-05 identifier or npub
- View profile information with ability to pay contact
- Search Contacts via name
- Refresh/Delete contact
@m1sterc001guy
Copy link
Collaborator

m1sterc001guy commented Jan 29, 2026

Ok I really like the PR and when playing around with it, it does work. There's a lot of features here though and I think we should probably split some of the functionality up so we know exact what we're adding.

I also want to take a second to consider the UX. Right now, a user can import their follows from Nostr and it will insert a bunch of stuff into the database. The UX of looking up a contact is awesome. But once they import their follows, I think most users would probably expect them to stay in sync with Nostr, whereas right now that doesn't happen and it makes the user manually delete or add after the initial import.

Would it be possible to do this?

  • Remove manually adding/removing individual contacts. Change the UI so that it just takes a NIP05 or npub to "link with Nostr" or something like that.
  • Our caching background thread that runs periodically in the background can periodically sync the contacts from Nostr to our DB after the initial import. It doesn't need to stay exactly in sync, maybe every few minutes or something it can sync from Nostr.
  • Remove the skip button, it's a little odd IMO that its there. Users can just dismiss the modal.
  • Remove the Nostr profile widget screen and the payment history with contacts. I like the feature, I just think its too much to merge in one PR. Let's do it in a follow up. Instead, when clicking a contact item, just bring up the number pad to begin the LN Address payment flow.
  • Don't import contacts who don't have an LN Address on their profile.

I think with the above changes, a lot of the #[frb] functions will be gone. This is a 12,000 line diff (most of it is generated code) so I think reducing the scope is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants