Skip to content

feat(web): onboarding select 启用 hover 提亮开关 #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qqqqqf-q merged 1 commit into from
Sep 14, 2026
Merged

feat(web): onboarding select 启用 hover 提亮开关 #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/web/src/pages/bots/components/model-select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
data-slot="select-trigger"
data-size="default"
:data-placeholder="displayLabel ? undefined : ''"
:data-hover-lighten="hoverLighten || undefined"

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin the UI revision that implements this attribute

In a clean checkout of this commit, packages/ui remains pinned to ea7c0c6b6e60a9ddfebbe9ee4d2ff5ba99f19b13, while the commit description states that data-hover-lighten is introduced only by a separate UI update. Consequently, this binding merely emits an unused DOM attribute and all three onboarding selects retain the invisible dark-theme hover behavior this change is meant to fix. Include the prerequisite gitlink bump before landing this commit.

AGENTS.md reference: AGENTS.md:L109-L109

Useful? React with 👍 / 👎.

type="button"
:aria-expanded="open"
:aria-invalid="invalid || undefined"
Expand Down Expand Up @@ -56,6 +57,10 @@ const props = defineProps<{
providers: ProvidersGetResponse[]
modelType: ModelsModelType
invalid?: boolean
// Opts into the ui package's data-hover-lighten escape hatch (white hover
// overlay in dark). For instances sitting directly on the near-black app
// canvas (onboarding), where the default pure-black hover fill is invisible.
hoverLighten?: boolean
placeholder?: string
noneLabel?: string
showReasoning?: boolean
Expand Down
5 changes: 4 additions & 1 deletion apps/web/src/pages/onboarding/steps/Step2Appearance.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ const { visible, exiting, leave } = useStepTransition()
:model-value="language"
@update:model-value="(value) => value && setLanguage(value as Locale)"
>
<SelectTrigger class="w-full">
<SelectTrigger
class="w-full"
data-hover-lighten
>
<SelectValue :placeholder="t('settings.languagePlaceholder')" />
</SelectTrigger>
<SelectContent>
Expand Down
5 changes: 4 additions & 1 deletion apps/web/src/pages/onboarding/steps/Step3Provider.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,10 @@ onMounted(() => {
</Label>
</template>
<Select v-model="formValues.client_type">
<SelectTrigger class="w-full">
<SelectTrigger
class="w-full"
data-hover-lighten
>
<SelectValue :placeholder="t('onboarding.provider.form.clientTypePlaceholder')" />
</SelectTrigger>
<SelectContent>
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/pages/onboarding/steps/Step4Bot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ async function handleSubmit() {
:providers="providers"
model-type="chat"
:placeholder="$t('onboarding.bot.model.selectPlaceholder')"
hover-lighten
/>
</template>
</div>
Expand Down
Loading