fix(fdroid): clean source build (remove prebuilt JAR + foojay) + metadata canonicalize, v2.0.3 - #3
Merged
Merged
Conversation
F-Droid's scanner rejected the build with two 'usual suspects': - the prebuilt PocketGopher.jar (removed; the .java/.jad reference files stay) - the Gradle foojay-resolver-convention plugin in settings.gradle.kts, which fetches JDK toolchains at build time (removed — no toolchain is requested, so it was inert) Also canonicalises fdroid/dev.debene.gopher.yml (rewritemeta format, no leading comments, AutoUpdateMode: Version) and bumps to 2.0.3 / versionCode 3 for a new tag containing these fixes. Verified: clean assembleRelease + unit tests pass, fdroid rewritemeta produces no diff, and the metadata passes schema validation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fdroiddata MR (!41663) pipeline failed. Root causes and fixes:
F-Droid build scanner (the
fdroid buildfailure)PocketGopher.jar— a prebuilt binary the scanner rejects. The originalPocketGopher.java(source) and.jad(text) stay; README updated.settings.gradle.kts— it downloads JDK toolchains at build time. NojvmToolchain/java.toolchainis declared, so it was inert; removing it has no effect on the build.Metadata format (the
fdroid rewritemeta+schema validationfailures)fdroid/dev.debene.gopher.ymlto matchfdroid rewritemeta(dropped leading comments, 2-space Description indent, unquoted versions).AutoUpdateMode: Version v%v→Version(thev%vform is rejected by the current schema).Version
Bumped to 2.0.3 / versionCode 3 so a new tag (
v2.0.3) can carry these fixes; the fdroiddata recipe now targets it.Verified locally
./gradlew clean assembleRelease testDebugUnitTest— green, without foojay.fdroid rewritemeta— produces no diff (file is canonical).check-jsonschemaagainst fdroiddata'sschemas/metadata.json— ok.After merge
Tag
v2.0.3on the merge commit and push it; then I'll update the fdroiddata MR's metadata to v2.0.3 and the pipeline will re-run.🤖 Generated with Claude Code