fix: ensure persistence don’t be empty after refresh page and remove products from LocalStorage when user remove any product from cart#29
Open
henriqpohl wants to merge 1 commit into
Conversation
…products from LocalStorage when user remove any product from cart
|
Someone is attempting to deploy a commit to a Personal Account owned by @felipemotarocha on Vercel. @felipemotarocha first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
After we did the persistent cart we got an error on the build process. It was previous fixed but after this the build process was successful but the persistent cart stopped working.
Every time after the user refreshes the page all objects inside the LocalStorage become empty.
Context:
These changes will ensure that the persistence cart will work on build process and on production and product will be deleted from LocalStorage when user removes it from cart.
Changes:
1: Create a LOCAL_STORAGE_KEY to make it easy to change or maintain in the future.
2: Pass the LocalStorage as String to ensure that it is the behavior.
3: Verify typeof window !== "undefined" if so, ".getItem()" to or ".setItem()" from LocalStorage.
4: Verify if "products.length" equal 0 if so, thats mean user removed some products from the cart and need to remove it from LocalStorage also.
Cheers! 🍺