Filter runs locally instead of via API query param#7
Closed
tobyjsullivan wants to merge 1 commit into
Closed
Conversation
The Github API can return stale results when the event param is used.
Author
|
Reopened the PR from my personal fork: #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Github API is currently returning stale results when the
eventquery param is supplied. They appear to be about 24 hours old. It seems likely that filtered results are eventually consistent and there's some sort of indexing delay on Github's side.Removing the
eventfilter from the API request returns up-to-date results. The results are filtered withjqinstead.