Debug fill function so it handles cases where no working directory de…

[qijuechenwsp]

…fined. Close files that are opened/edited by gdal.

Hi there, Thomas and I are using overflow in our sinkhole tool and find that when working directory is not defined in fill function, it would report error like "/...system path.../label.tif" is in use. I tested the before and after versions for the edits I made here and believe fill_depressions_tiled.py is the cause and added lines should fix it.

[barne856]

Hey thanks for contributing, it looks like this has to do with the way Windows operates and so it makes sense why this never surfaced in development as we've only developed and tested in Linux or in containers. Windows does not allow files to be deleted if they are open, so the rmtree here needs to happen after the datasets are closed. We've used = None to close datasets since .Close() was introduced in GDAL >= 3.7. If we use that API we'll need to bump the minimum version from 3.6 to 3.7 in the pyproject.toml which shouldn't be an issue as 3.7 is several years old at this point later versions are available in ArcGIS Pro and many Linux distribution's repositories.

I also noticed a similar issue in the resolve flats process which should also be fixed. I'll push a commit with the changes.