Skip to content

Feature: Add Goal Icons and Tests#138

Open
dokuparthijoshna-commits wants to merge 2 commits intofencer-so:mainfrom
dokuparthijoshna-commits:feature/task-5
Open

Feature: Add Goal Icons and Tests#138
dokuparthijoshna-commits wants to merge 2 commits intofencer-so:mainfrom
dokuparthijoshna-commits:feature/task-5

Conversation

@dokuparthijoshna-commits
Copy link
Copy Markdown

In this task, I implemented full support for goal icons across the application.

Frontend:

  • Extended Goal model to include an optional icon field
  • Displayed icon in GoalCard component
  • Integrated emoji picker using emoji-mart
  • Updated GoalManager to allow selecting and updating icons

Backend/API:

  • Added PUT request support to update goals

Testing:

  • Added unit test to cover GetGoalsForUser route in GoalControllerTests

This ensures that users can select, update, and persist goal icons successfully.

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 24, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials d2112fa CommBank-Server/appsettings.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant