Skip to content

Implemented goal icon feature, emoji picker, and tests#143

Open
tsega36 wants to merge 2 commits intofencer-so:mainfrom
tsega36:icon-implementation
Open

Implemented goal icon feature, emoji picker, and tests#143
tsega36 wants to merge 2 commits intofencer-so:mainfrom
tsega36:icon-implementation

Conversation

@tsega36
Copy link
Copy Markdown

@tsega36 tsega36 commented Mar 27, 2026

Changes

  • Added optional icon field to Goal model (backend)
  • Updated API to return icon
  • Updated frontend Goal model
  • Displayed icon on Goal card
  • Implemented emoji picker using emoji-mart
  • Enabled users to add/change goal icons
  • Added PUT request to persist icon updates
  • Completed unit test for GetGoalsForUser route

Testing

  • Verified API responses via Postman
  • Confirmed icon persists after refresh
  • All unit tests passing

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 27, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 594dc63 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@tsega36 tsega36 closed this Mar 27, 2026
@tsega36 tsega36 reopened this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant