Skip to content

Add first arrival bus coordinates to the arrival data #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luca-angemi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add first arrival bus coordinates to the arrival data #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
197478e
Add bus_coords attribute to Line class
luca-angemi Dec 1, 2025
a55333e
Add bus coordinates handling in arrival data processing
luca-angemi Dec 1, 2025
f529d0a
Remove unused 'coords' variable
luca-angemi Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions emt_madrid/domain/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class Line:
day_type: Optional[DayType] = None
arrival: Optional[int] = None
next_arrival: Optional[int] = None
bus_coords: Optional[list[float]] = None

def __str__(self) -> str:
"""Return a string representation of the line."""
Expand Down
10 changes: 10 additions & 0 deletions emt_madrid/infrastructure/emt_api_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,22 @@ async def get_arrivals(self, stop: Stop) -> Stop:
if not sorted_arrivals:
line.arrival = None
line.next_arrival = None
line.bus_coords = None
else:
line.arrival = sorted_arrivals[0]
line.next_arrival = (
sorted_arrivals[1] if len(sorted_arrivals) > 1 else None
)

bus_for_line = [
a for a in arrivals_data if str(a["line"]) == line.line_number
]
if bus_for_line:
first_bus = min(bus_for_line, key=lambda x: int(x["estimateArrive"]))
line.bus_coords = first_bus["geometry"]["coordinates"]
else:
line.bus_coords = None

return stop

except Exception as e:
Expand Down