MBTI64-ZH32-EN32-V8_5-V5-SEARCH-FRESHNESS-GATE-01#2569
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 133ea11ba7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $fixedSubsetIssues = $this->fixedV85V5Bilingual64Issues($targets); | ||
| if ($fixedSubsetIssues !== []) { | ||
| return $this->finish($this->payload('NO_GO_SAFETY_VIOLATION', $fixedSubsetIssues)); |
There was a problem hiding this comment.
Validate fixed-package input before empty-target return
When --v8-5-v5-bilingual-64 is used with a missing/unreadable/malformed package, or a package that contains no valid recommendations[*].target_url, targets() returns an empty list and the method has already returned target_urls_missing before this fixed-package contract check runs. finish() treats that non-safety NO_GO as exit code 0, so a CI/release script relying on the command status can proceed without ever validating the locked package hash or exact URL contract. Move this validation ahead of the empty-target return, or make empty targets in fixed mode a safety violation.
Useful? React with 👍 / 👎.
What changed
--v8-5-v5-bilingual-64mode topersonality:agent-post-promotion-search-gate.Why
After V8.5/V5 promotion, the search-release gate needs a bounded 64-page path before URL Truth refresh / IndexNow dry-run decisions. This keeps post-promotion search checks scoped to the approved bilingual MBTI64 package and prevents accidental package drift, comparison pages, private paths, or arbitrary URL subsets from entering the search-release planning path.
Validation
php -l app/Console/Commands/PersonalityAgentPostPromotionSearchGateCommand.phpphp -l tests/Feature/SeoIntel/PersonalityAgentPostPromotionSearchGateCommandTest.phpphp artisan test tests/Feature/SeoIntel/PersonalityAgentPostPromotionSearchGateCommandTest.php --display-warningsbash backend/scripts/ci_verify_mbti.shgit diff --checkDeferred
Repository rule impact
Backend remains the authority for URL Truth, Search Queue planning, CMS promotion, and public content state. This PR adds a bounded read-only gate contract only; it does not move content/search authority to frontend or local files.