Skip to content

MBTI-DESKTOP-CLONE-TRAITS-UNLOCK-CONTENT-01: thicken zh-CN traits unlock content#2571

Merged
fermatmind merged 6 commits into
mainfrom
codex/mbti-desktop-clone-traits-unlock-content-01
Jul 1, 2026
Merged

MBTI-DESKTOP-CLONE-TRAITS-UNLOCK-CONTENT-01: thicken zh-CN traits unlock content#2571
fermatmind merged 6 commits into
mainfrom
codex/mbti-desktop-clone-traits-unlock-content-01

Conversation

@fermatmind

Copy link
Copy Markdown
Owner

Summary

  • Rewrites the zh-CN MBTI desktop clone traits_unlock.items copy for all 32 fullCode variants.
  • Focuses on career, growth, and relationships influential trait unlock details.
  • Splits copy by trait role and MBTI A/T behavior so the four items inside each fullCode are no longer block-level repeats.

Why

The result-page influential trait unlock panels had repeated/template-like bodies, especially in relationships where several traits shared the same explanation with only the label swapped. This PR keeps the existing schema but makes each trait body map to its title, chapter context, and A/T pressure/feedback/relationship behavior.

Scope

  • Backend content asset only.
  • Modified: content_baselines/personality_clone/mbti_desktop_clone.zh-CN.json.
  • No frontend changes.
  • No English baseline changes; mbti_desktop_clone.en.json should be handled in a separate PR.
  • No schema, importer, API, PDF, DB, CMS, or deployment changes.

Validation

  • python3 -m json.tool content_baselines/personality_clone/mbti_desktop_clone.zh-CN.json >/dev/null
  • Custom content quality check over 32 variants / 2688 traits_unlock fields ✅
    • 4 items per chapter checked
    • no duplicate field body inside the same fullCode chapter
    • no placeholder text in rewritten fields
    • A/T pair blocks are not identical
  • php artisan personality:import-local-baseline --dry-run --locale=zh-CN --status=published
  • php artisan personality:import-local-baseline --locale=zh-CN --status=published ✅ local dev DB prerequisite only; no repo diff
  • php artisan personality:import-desktop-clone-baseline --dry-run --locale=zh-CN
  • php artisan test tests/Feature/PersonalityCms/PersonalityDesktopCloneBaselineImportTest.php tests/Feature/PersonalityCms/PersonalityDesktopCloneSchemaModelTest.php tests/Feature/V0_5/PersonalityDesktopClonePublicApiTest.php ✅ 24 passed
  • git diff --check

Intentionally Deferred

  • English mbti_desktop_clone.en.json content rewrite.
  • Public personality profile assets.
  • Legacy PDF/report packages.
  • Frontend rendering changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/fermatmind/fap-api/blob/b471d5fb2d20245cfab7b771af564d8a66d6d55b/content_baselines/personality_clone/mbti_desktop_clone.zh-CN.json#L1707
P2 Badge Use the established T-label in unlock copy

For *-T zh-CN profiles, the surrounding report copy already presents the A/T identity as 敏感型 (for example this same chapter intro says 敏感型), but the newly generated traits_unlock body switches to 动荡侧/动荡型. Users opening any T variant will see the identity terminology change within the same unlock panel, which makes the report look inconsistent; the new unlock text should use the existing 敏感型 wording.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/fermatmind/fap-api/blob/187067c42e9a3d730db2b96735e2e23bdcb0963f/content_baselines/personality_clone/mbti_desktop_clone.zh-CN.json#L32972
P2 Badge Update the remaining ISTP-T labels

For ISTP-T imports, this changes profile_identity.name to 鉴赏家型 while the same variant still says 探险家型 in chapters.career/growth/relationships.intro[0] and related locked overlay copy, so the public report can show two different type names for one result. Please update the remaining ISTP-T copy, or keep the old name consistently, in this baseline row.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/fermatmind/fap-api/blob/3d68e3b5641d27016fc836a9934e41ab31bb634d/content_baselines/personality_clone/mbti_desktop_clone.zh-CN.json#L18843
P2 Badge Use the ENFP-A display name consistently

In the ENFP-A variant, profile_identity.name remains 活动家型, but the new traits-unlock copy switches to 竞选型 in user-visible paragraphs. Users unlocking ENFP-A will now see two different type names in the same report; this copy should use the ENFP-A display name consistently, or the identity and all related copy should be renamed together.


https://github.com/fermatmind/fap-api/blob/3d68e3b5641d27016fc836a9934e41ab31bb634d/content_baselines/personality_clone/mbti_desktop_clone.zh-CN.json#L32972
P2 Badge Finish renaming ISTP-T copy to the new display name

This changes the ISTP-T identity name from 探险家型 to 鉴赏家型, but the same variant still has user-visible intro, locked-block, and final-offer strings that say 探险家型. An ISTP-T user will now see conflicting type names across the report, so either keep the old name or update the remaining ISTP-T baseline text in the same change.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fermatmind fermatmind merged commit 494ca21 into main Jul 1, 2026
15 checks passed
@fermatmind fermatmind deleted the codex/mbti-desktop-clone-traits-unlock-content-01 branch July 1, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant