Skip to content

MBTI-DESKTOP-CLONE-LOCKED-BLOCKS-CONTENT-01: improve MBTI desktop clone locked block content#2575

Merged
fermatmind merged 4 commits into
mainfrom
codex/mbti-desktop-clone-locked-blocks-content-01
Jul 1, 2026
Merged

MBTI-DESKTOP-CLONE-LOCKED-BLOCKS-CONTENT-01: improve MBTI desktop clone locked block content#2575
fermatmind merged 4 commits into
mainfrom
codex/mbti-desktop-clone-locked-blocks-content-01

Conversation

@fermatmind

@fermatmind fermatmind commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Registered PR-train item MBTI-DESKTOP-CLONE-LOCKED-BLOCKS-CONTENT-01.
  • Rewrote zh-CN and en MBTI desktop clone chapters.career/growth/relationships.lockedBlocks body-like teaser copy across all 32 fullCode variants.
  • Cleaned English chapter intros and a small set of visibly generated English visibleBlock lines while preserving schema and importer compatibility.
  • Follow-up validation re-audited all 32 fullCodes and resolved the local locale=en fixture gate by initializing local development DB owner rows from the existing public personality baseline importer.

Why

The remaining MBTI desktop clone result-page content quality gaps were outside traits_unlock: locked teaser copy had template repetition, weak A/T distinction, generated English scaffolding, and compact teaser text that did not consistently anchor to the item title, chapter, and type pattern.

Content Authority / Scope

  • Backend baseline content only.
  • No frontend changes.
  • No PDF changes.
  • No public personality profile content changes.
  • No legacy report/PDF package changes.
  • No schema/importer/API/runtime logic changes.
  • No production DB/CMS writes, cache clearing, deployment, or server actions.

Validation

Passed:

  • python3 -m json.tool content_baselines/personality_clone/mbti_desktop_clone.zh-CN.json >/dev/null
  • python3 -m json.tool content_baselines/personality_clone/mbti_desktop_clone.en.json >/dev/null
  • python3 -m json.tool docs/codex/pr-train-state.json >/dev/null
  • ruby -e 'require "yaml"; YAML.load_file("docs/codex/pr-train.yaml"); puts "yaml ok"'
  • custom content audit:
    • zh-CN/en: 32 variants each
    • lockedBlocks body rows: 1344 each
    • visibleBlocks body rows: 1152 each
    • exact duplicate body text: 0
    • A/T same-path body cells: 0
    • placeholder/debug/generated/formula/hard-absolute scan hits: 0
    • manual samples reviewed: INTJ-A/T, ENFP-A/T, INFJ-T, ESTJ-A, ISFP-T, ISTP-A
  • php artisan personality:import-local-baseline --dry-run --locale=en --source-dir=../content_baselines/personality
    • profiles_found=16, variants_found=32, errors_count=0
  • php artisan personality:import-local-baseline --locale=en --status=published --upsert --source-dir=../content_baselines/personality
    • local development DB setup only; no production import
    • created/updated local owner rows needed for desktop clone dry-run
  • local DB owner row verification:
    • profiles_en=16
    • variants_en=32
  • php artisan personality:import-desktop-clone-baseline --dry-run --locale=zh-CN
    • rows_found=32, errors_count=0
  • php artisan personality:import-desktop-clone-baseline --dry-run --locale=en
    • rows_found=32, errors_count=0
  • php artisan test tests/Feature/PersonalityCms/PersonalityDesktopCloneBaselineImportTest.php tests/Feature/PersonalityCms/PersonalityDesktopCloneSchemaModelTest.php tests/Feature/V0_5/PersonalityDesktopClonePublicApiTest.php
    • 24 passed, 1394 assertions
  • git diff --check

Fixture Gate Resolution

The earlier Missing personality_profile_variant for full_code=ENFJ-A locale=en failure was not a desktop clone baseline missing-row issue. Local DB had 0 English MBTI authority variants. Running the existing personality:import-local-baseline command for locale=en initialized the local owner rows, after which the English desktop clone dry-run passed for all 32 fullCodes.

Intentionally Deferred

  • No production import.
  • No DB/CMS mutation outside local development fixture setup.
  • No deployment.
  • No frontend/PDF work.
  • No further traits_unlock rewrite in this PR.
  • English public profile / legacy report package content remains out of scope.

@fermatmind fermatmind marked this pull request as ready for review July 1, 2026 11:24
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/fermatmind/fap-api/blob/2df2c75825b73a68fe0d5a6d47caccf6824cd063/content_baselines/personality_clone/mbti_desktop_clone.en.json#L297
P2 Badge Fix singular verb in generated English overlays

When an English user opens the first locked-block preview, this new template renders how [plural trait list] affects ...; the same how ... affects overlay text appears 96 times across the English career/growth/relationships locked blocks, so every English variant ships visibly broken teaser copy even though the content audit passes.


https://github.com/fermatmind/fap-api/blob/2df2c75825b73a68fe0d5a6d47caccf6824cd063/content_baselines/personality_clone/mbti_desktop_clone.en.json#L274
P2 Badge Fix plural-title visible block copy

For English visible friction items whose inserted title is plural, the new template emits copy like Rigid boundaries starts...; this pattern appears in 23 visible rows, so users see grammatical errors in the free/visible result-page content this commit is meant to clean up.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/fermatmind/fap-api/blob/2b36fa27d3e2a9ba3934ef4c0e645725868cf29c/content_baselines/personality_clone/mbti_desktop_clone.en.json#L274
P2 Badge Fix generated subject-verb mismatches

When the English desktop-clone baseline is imported, this user-facing copy is served in the career friction block, and the new template produces ungrammatical text such as Rigid boundaries starts.... The same generated pattern appears in many other changed EN entries (Delayed boundaries starts, Loose boundaries starts, etc.), so the PR meant to improve content quality still ships visibly broken English; please correct the template/output before publishing the baseline.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fermatmind fermatmind merged commit 29c0aed into main Jul 1, 2026
15 checks passed
@fermatmind fermatmind deleted the codex/mbti-desktop-clone-locked-blocks-content-01 branch July 1, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant